Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate --workspace_status_command's value #5034

Closed
laszlocsomor opened this issue Apr 17, 2018 · 3 comments
Closed

validate --workspace_status_command's value #5034

laszlocsomor opened this issue Apr 17, 2018 · 3 comments
Assignees
Labels
category: misc > misc P3 We're not considering working on this, but happy to review a PR. (No assignee) type: feature request

Comments

@laszlocsomor
Copy link
Contributor

laszlocsomor commented Apr 17, 2018

Description of the problem / feature request:

Bazel should check that --workspace_status_command's value is a path, not a raw shell command string.

Feature requests: what underlying problem are you trying to solve with this feature?

Remove the need for Bazel to run the command through Bash as part of issue #4319.

The documentation already says the flag expects a path, but nothing validates the flag's value. If the flag's value is a path to a binary or script, then, as long as those are valid executables or have valid shebang lines, Bazel can successfully run them even without Bash.

What operating system are you running Bazel on?

Any.

What's the output of bazel info release?

0.12.0

Have you found anything relevant by searching the web?

Culprit of: #5028
Blocker of: #2190

@laszlocsomor laszlocsomor self-assigned this Apr 17, 2018
@laszlocsomor laszlocsomor added type: feature request P3 We're not considering working on this, but happy to review a PR. (No assignee) labels Apr 17, 2018
@laszlocsomor
Copy link
Contributor Author

Closely related: #4802

@laszlocsomor
Copy link
Contributor Author

I was wrong, --workspace_status_command cannot expect a path lest it would be unusable in bazelrc files if you run the build on multiple platforms. I guess @ulfjack is right in #5002 (comment), and we must support an actual shell command.

@laszlocsomor
Copy link
Contributor Author

Obsolete, won't fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: misc > misc P3 We're not considering working on this, but happy to review a PR. (No assignee) type: feature request
Projects
None yet
Development

No branches or pull requests

2 participants