Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

orphaned remote cached actions fallback broken #4585

Closed
ola-rozenfeld opened this issue Feb 5, 2018 · 0 comments
Closed

orphaned remote cached actions fallback broken #4585

ola-rozenfeld opened this issue Feb 5, 2018 · 0 comments
Assignees
@ola-rozenfeld
Labels
type: bug

Comments

@ola-rozenfeld
Copy link
Contributor

When a remotely cached action result contains remotely missing file contents, the code is supposed to fallback to re-executing the action remotely. This is unit-tested as well. It is, however, still broken with gRPC remote cache, and the error bypasses the inadequate unit test.
@ola-rozenfeld ola-rozenfeld self-assigned this Feb 5, 2018
bazel-io pushed a commit that referenced this issue Feb 8, 2018
Fixing #4585: broken re-execution of orphaned actions.
56aeb04 
This is an important regression, we will want to patch the fix into 0.10

TESTED=fixed unit test, with A/B testing
RELNOTES: Resolved an issue where a failure in the remote cache would not trigger local re-execution of an action.
PiperOrigin-RevId: 184991670
@katre katre mentioned this issue Feb 8, 2018
Closed
katre pushed a commit that referenced this issue Feb 9, 2018
@katre
Fixing #4585: broken re-execution of orphaned actions.
24fdeef 
This is an important regression, we will want to patch the fix into 0.10

TESTED=fixed unit test, with A/B testing
RELNOTES: Resolved an issue where a failure in the remote cache would not trigger local re-execution of an action.
PiperOrigin-RevId: 184991670
iirina pushed a commit that referenced this issue Feb 12, 2018
@iirina
Fixing #4585: broken re-execution of orphaned actions.
b403577 
This is an important regression, we will want to patch the fix into 0.10

TESTED=fixed unit test, with A/B testing
RELNOTES: Resolved an issue where a failure in the remote cache would not trigger local re-execution of an action.
PiperOrigin-RevId: 184991670
katre pushed a commit that referenced this issue Feb 12, 2018
@katre
Fixing #4585: broken re-execution of orphaned actions.
ec6c99f 
This is an important regression, we will want to patch the fix into 0.10

TESTED=fixed unit test, with A/B testing
RELNOTES: Resolved an issue where a failure in the remote cache would not trigger local re-execution of an action.
PiperOrigin-RevId: 184991670
bazel-io pushed a commit that referenced this issue Feb 15, 2018
@iirina
Release 0.10.1 (2018-02-15)
e114836 
Baseline: 22c2f9a

Cherry picks:
   + f6ca788:
     isable_presubmit
   + 65c13dd:
     Fix StreamResourceLeak error
   + e543674:
     windows: fix --symlink_prefix=/ throwing exception
   + 22ccdd1:
     Fix turbine command lines with empty javacopts
   + 96c654d:
     Remove EOL'd Linux flavours, bump CentOS to 6.9.
   + f0bec36:
     Automated rollback of commit
     2aeaeba.
   + 860af5b:
     Consolidate Error Prone resource handling
   + 2e631c9:
     sandbox: properly add `tmpDir` to `writablePaths`
   + 5bfa584:
     actions,temp: respect TMPDIR envvar
   + 6cc2ad8:
     sandbox: add env[TMPDIR] instead of `tmpDir`
   + 40c757f:
     Change git clone to pull all history, so all needed commits can
     be accessed.
   + 56aeb04:
     Fixing #4585: broken re-execution of orphaned actions.

Important changes:

  - Resolved an issue where a failure in the remote cache would not
    trigger local re-execution of an action.
mmorearty pushed a commit to Asana/bazel that referenced this issue Feb 16, 2018
@iirina
Release 0.10.1 (2018-02-15)
65222eb 
Baseline: 22c2f9a

Cherry picks:
   + f6ca788:
     isable_presubmit
   + 65c13dd:
     Fix StreamResourceLeak error
   + e543674:
     windows: fix --symlink_prefix=/ throwing exception
   + 22ccdd1:
     Fix turbine command lines with empty javacopts
   + 96c654d:
     Remove EOL'd Linux flavours, bump CentOS to 6.9.
   + f0bec36:
     Automated rollback of commit
     2aeaeba.
   + 860af5b:
     Consolidate Error Prone resource handling
   + 2e631c9:
     sandbox: properly add `tmpDir` to `writablePaths`
   + 5bfa584:
     actions,temp: respect TMPDIR envvar
   + 6cc2ad8:
     sandbox: add env[TMPDIR] instead of `tmpDir`
   + 40c757f:
     Change git clone to pull all history, so all needed commits can
     be accessed.
   + 56aeb04:
     Fixing bazelbuild#4585: broken re-execution of orphaned actions.

Important changes:

  - Resolved an issue where a failure in the remote cache would not
    trigger local re-execution of an action.
katre pushed a commit that referenced this issue Feb 20, 2018
@katre
Fixing #4585: broken re-execution of orphaned actions.
28c463c 
This is an important regression, we will want to patch the fix into 0.10

TESTED=fixed unit test, with A/B testing
RELNOTES: Resolved an issue where a failure in the remote cache would not trigger local re-execution of an action.
PiperOrigin-RevId: 184991670
bazel-io pushed a commit that referenced this issue Feb 23, 2018
@katre
Release 0.11.0 (2018-02-23)
09077a3 
Baseline: 00d781a

Cherry picks:
   + ea2d4c4:
     Update stub_finds_runfiles_test to be a real sh_test.
   + d855d81:
     java,runfiles: fix bugs in runfiles library
   + 56aeb04:
     Fixing #4585: broken re-execution of orphaned actions.
   + cf3f81a:
     remote: Add support for HTTP Basic Auth
   + 28bd997:
     Fixing test-setup.sh occasionally missing stdout/stderr, on
     systems where "tail --pid" is supported.
   + 109e4b4:
     Automated rollback of commit
     7e6837c.
   + b3d52b1:
     Fix incorrect include directories when -no-canonical-prefixes is
     passed to clang
   + 3904ac3:
     Automated rollback of commit
     28bd997.
   + 1001141:
     Roll forward of
     3904ac33a983fd8faebba1
     b52bcac5a3ff942029
     (3904ac33a983fd8faebba
     1b52bcac5a3ff942029). Fix #4625 by running the test process in a
     sub-shell.

Incompatible changes:

  - ctx.fragments.jvm is not available anymore.

New features:

  - java,runfiles: You can now depend on
    `@bazel_tools//tools/runfiles:java-runfiles` to get a
    platform-independent runfiles library for Java. See JavaDoc of
    https://github.com/bazelbuild/bazel/blob/master/src/tools/runfiles
    /java/com/google/devtools/build/runfiles/Runfiles.java for usage
    information.

Important changes:

  - The --[no]experimental_disable_jvm command line option is not
    supported anymore.
  - Allow expanding TreeArtifacts for libraries_to_link
  - Proguarded Android binaries can be built with incremental dexing.
  - aar_import now supports assets.
  - Crash in OutputJar::Close has been fixed
  - generator_* attributes are nonconfigurable.
  - Introduces --[no]keep_state_after_build
  - Add support for merged object files needed for -flto-unit.
  - Fix how libraries to link is specified to archiver actions.
  - Replace //tools/defaults:android_jar with
    @bazel_tools//tools/android:android_jar.
    //tools/defaults:android_jar will be removed in a future release.
  - java_common.compile supports neverlink
  - Resolved an issue where a failure in the remote cache would not
    trigger local re-execution of an action.
mmorearty pushed a commit to Asana/bazel that referenced this issue Feb 23, 2018
@katre
Release 0.11.0 (2018-02-23)
c642041 
Baseline: 00d781a

Cherry picks:
   + ea2d4c4:
     Update stub_finds_runfiles_test to be a real sh_test.
   + d855d81:
     java,runfiles: fix bugs in runfiles library
   + 56aeb04:
     Fixing bazelbuild#4585: broken re-execution of orphaned actions.
   + cf3f81a:
     remote: Add support for HTTP Basic Auth
   + 28bd997:
     Fixing test-setup.sh occasionally missing stdout/stderr, on
     systems where "tail --pid" is supported.
   + 109e4b4:
     Automated rollback of commit
     7e6837c.
   + b3d52b1:
     Fix incorrect include directories when -no-canonical-prefixes is
     passed to clang
   + 3904ac3:
     Automated rollback of commit
     28bd997.
   + 1001141:
     Roll forward of
     bazelbuild@3904ac33a983fd8faebba1
     b52bcac5a3ff942029
     (bazelbuild@3904ac33a983fd8faebba
     1b52bcac5a3ff942029). Fix bazelbuild#4625 by running the test process in a
     sub-shell.

Incompatible changes:

  - ctx.fragments.jvm is not available anymore.

New features:

  - java,runfiles: You can now depend on
    `@bazel_tools//tools/runfiles:java-runfiles` to get a
    platform-independent runfiles library for Java. See JavaDoc of
    https://github.com/bazelbuild/bazel/blob/master/src/tools/runfiles
    /java/com/google/devtools/build/runfiles/Runfiles.java for usage
    information.

Important changes:

  - The --[no]experimental_disable_jvm command line option is not
    supported anymore.
  - Allow expanding TreeArtifacts for libraries_to_link
  - Proguarded Android binaries can be built with incremental dexing.
  - aar_import now supports assets.
  - Crash in OutputJar::Close has been fixed
  - generator_* attributes are nonconfigurable.
  - Introduces --[no]keep_state_after_build
  - Add support for merged object files needed for -flto-unit.
  - Fix how libraries to link is specified to archiver actions.
  - Replace //tools/defaults:android_jar with
    @bazel_tools//tools/android:android_jar.
    //tools/defaults:android_jar will be removed in a future release.
  - java_common.compile supports neverlink
  - Resolved an issue where a failure in the remote cache would not
    trigger local re-execution of an action.
katre pushed a commit that referenced this issue Feb 28, 2018
@katre
Fixing #4585: broken re-execution of orphaned actions.
ca2dfa2 
This is an important regression, we will want to patch the fix into 0.10

TESTED=fixed unit test, with A/B testing
RELNOTES: Resolved an issue where a failure in the remote cache would not trigger local re-execution of an action.
PiperOrigin-RevId: 184991670
werkt pushed a commit to werkt/bazel that referenced this issue Mar 2, 2018
Fixing bazelbuild#4585: broken re-execution of orphaned actions.
3122c5f 
This is an important regression, we will want to patch the fix into 0.10

TESTED=fixed unit test, with A/B testing
RELNOTES: Resolved an issue where a failure in the remote cache would not trigger local re-execution of an action.
PiperOrigin-RevId: 184991670
werkt pushed a commit to werkt/bazel that referenced this issue Mar 2, 2018
Release 0.10.1 (2018-02-15)
05e42e0 
Baseline: 22c2f9a

Cherry picks:
   + f6ca788:
     isable_presubmit
   + 65c13dd:
     Fix StreamResourceLeak error
   + e543674:
     windows: fix --symlink_prefix=/ throwing exception
   + 22ccdd1:
     Fix turbine command lines with empty javacopts
   + 96c654d:
     Remove EOL'd Linux flavours, bump CentOS to 6.9.
   + f0bec36:
     Automated rollback of commit
     2aeaeba.
   + 860af5b:
     Consolidate Error Prone resource handling
   + 2e631c9:
     sandbox: properly add `tmpDir` to `writablePaths`
   + 5bfa584:
     actions,temp: respect TMPDIR envvar
   + 6cc2ad8:
     sandbox: add env[TMPDIR] instead of `tmpDir`
   + 40c757f:
     Change git clone to pull all history, so all needed commits can
     be accessed.
   + 56aeb04:
     Fixing bazelbuild#4585: broken re-execution of orphaned actions.

Important changes:

  - Resolved an issue where a failure in the remote cache would not
    trigger local re-execution of an action.
werkt pushed a commit to werkt/bazel that referenced this issue Mar 2, 2018
Release 0.10.1 (2018-02-15)
d085337 
Baseline: 22c2f9a

Cherry picks:
   + f6ca788:
     isable_presubmit
   + 65c13dd:
     Fix StreamResourceLeak error
   + e543674:
     windows: fix --symlink_prefix=/ throwing exception
   + 22ccdd1:
     Fix turbine command lines with empty javacopts
   + 96c654d:
     Remove EOL'd Linux flavours, bump CentOS to 6.9.
   + f0bec36:
     Automated rollback of commit
     2aeaeba.
   + 860af5b:
     Consolidate Error Prone resource handling
   + 2e631c9:
     sandbox: properly add `tmpDir` to `writablePaths`
   + 5bfa584:
     actions,temp: respect TMPDIR envvar
   + 6cc2ad8:
     sandbox: add env[TMPDIR] instead of `tmpDir`
   + 40c757f:
     Change git clone to pull all history, so all needed commits can
     be accessed.
   + 56aeb04:
     Fixing bazelbuild#4585: broken re-execution of orphaned actions.

Important changes:

  - Resolved an issue where a failure in the remote cache would not
    trigger local re-execution of an action.
werkt pushed a commit to werkt/bazel that referenced this issue Mar 2, 2018
Fixing bazelbuild#4585: broken re-execution of orphaned actions.
e445470 
This is an important regression, we will want to patch the fix into 0.10

TESTED=fixed unit test, with A/B testing
RELNOTES: Resolved an issue where a failure in the remote cache would not trigger local re-execution of an action.
PiperOrigin-RevId: 184991670
philwo pushed a commit that referenced this issue Mar 6, 2018
@philwo
Fixing #4585: broken re-execution of orphaned actions.
5a1face 
This is an important regression, we will want to patch the fix into 0.10

TESTED=fixed unit test, with A/B testing
RELNOTES: Resolved an issue where a failure in the remote cache would not trigger local re-execution of an action.
PiperOrigin-RevId: 184991670
bazel-io pushed a commit that referenced this issue Mar 6, 2018
@philwo
Release 0.11.1 (2018-03-06)
c86d6a0 
Baseline: 00d781a

Cherry picks:
   + ea2d4c4:
     Update stub_finds_runfiles_test to be a real sh_test.
   + d855d81:
     java,runfiles: fix bugs in runfiles library
   + 56aeb04:
     Fixing #4585: broken re-execution of orphaned actions.
   + cf3f81a:
     remote: Add support for HTTP Basic Auth
   + 28bd997:
     Fixing test-setup.sh occasionally missing stdout/stderr, on
     systems where "tail --pid" is supported.
   + 109e4b4:
     Automated rollback of commit
     7e6837c.
   + b3d52b1:
     Fix incorrect include directories when -no-canonical-prefixes is
     passed to clang
   + 1001141:
     Roll forward of
     3904ac33a983fd8faebba1
     b52bcac5a3ff942029
     (3904ac33a983fd8faebba
     1b52bcac5a3ff942029). Fix #4625 by running the test process in a
     sub-shell.
   + fc98b44:
     android,windows: bugfix in aar_resources_extractor

Important changes:

  - Fixes regression building Android rules on Windows.
mmorearty pushed a commit to Asana/bazel that referenced this issue Mar 7, 2018
@philwo
Release 0.11.1 (2018-03-06)
71932dd 
Baseline: 00d781a

Cherry picks:
   + ea2d4c4:
     Update stub_finds_runfiles_test to be a real sh_test.
   + d855d81:
     java,runfiles: fix bugs in runfiles library
   + 56aeb04:
     Fixing bazelbuild#4585: broken re-execution of orphaned actions.
   + cf3f81a:
     remote: Add support for HTTP Basic Auth
   + 28bd997:
     Fixing test-setup.sh occasionally missing stdout/stderr, on
     systems where "tail --pid" is supported.
   + 109e4b4:
     Automated rollback of commit
     7e6837c.
   + b3d52b1:
     Fix incorrect include directories when -no-canonical-prefixes is
     passed to clang
   + 1001141:
     Roll forward of
     bazelbuild@3904ac33a983fd8faebba1
     b52bcac5a3ff942029
     (bazelbuild@3904ac33a983fd8faebba
     1b52bcac5a3ff942029). Fix bazelbuild#4625 by running the test process in a
     sub-shell.
   + fc98b44:
     android,windows: bugfix in aar_resources_extractor

Important changes:

  - Fixes regression building Android rules on Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ola-rozenfeld ola-rozenfeld

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@katre @ola-rozenfeld