Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ExecutionPlatformConstraintsAllowed #8134

Closed
katre opened this issue Apr 24, 2019 · 0 comments
Closed

Remove ExecutionPlatformConstraintsAllowed #8134

katre opened this issue Apr 24, 2019 · 0 comments
Assignees
@katre
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Configurability Issues for Configurability team type: feature request

Comments

@katre
Copy link
Member

katre commented Apr 24, 2019

This is the overall issue to track removing ExecutionPlatformConstraintsAllowed, the capability for individual rule classes to allow or disallow targets from using exec_compatible_with to restrict the execution platform.

After this change is finished, all targets will allow this.

Pace of work:

  1. Enable exec_compatible_with for all native rules. May also deprecate the RuleClass.Builder method that controls this.
  2. Create an incompatible change issue to track removing the execution_platform_constraints_allowed attribute from the rule() method in Starlark.
  3. Remove the actual functionality.

Finishing part 1 will fix #8026.
katre added a commit to katre/bazel that referenced this issue Apr 24, 2019
@katre
Allow all native rules to use "exec_compatible_with" to specify
221fd5f 
additional constraints on the execution platform.

Part of work on bazelbuild#8134.
Fixes bazelbuild#8026.
@katre katre mentioned this issue Apr 24, 2019
Closed
@katre katre self-assigned this Apr 24, 2019
@katre katre added P2 We'll consider working on this in future. (Assignee optional) team-Configurability Issues for Configurability team type: feature request labels Apr 24, 2019
@katre katre mentioned this issue Apr 24, 2019
Closed
bazel-io pushed a commit that referenced this issue Apr 25, 2019
@katre
Allow all native rules to use "exec_compatible_with" to specify
a0f88c0 
additional constraints on the execution platform.

Part of work on #8134.
Fixes #8026.

Closes #8135.

PiperOrigin-RevId: 245227990
katre added a commit to katre/bazel that referenced this issue Apr 25, 2019
@katre
Add incompatible_disallow_rule_execution_platform_constraints_allowed
34b77b7 
flag.

Part of bazelbuild#8136 and bazelbuild#8134.

RELNOTES: Adds
incompatible_disallow_rule_execution_platform_constraints_allowed, which
disallows the use of the "execution_platform_constraints_allowed"
attribute when defining new rules.
@katre katre mentioned this issue Apr 25, 2019
Closed
katre added a commit to katre/bazel that referenced this issue Apr 26, 2019
@katre
Add incompatible_disallow_rule_execution_platform_constraints_allowed…
5688793 
… flag.

Part of bazelbuild#8136 and bazelbuild#8134.

RELNOTES: Adds
incompatible_disallow_rule_execution_platform_constraints_allowed, which
disallows the use of the "execution_platform_constraints_allowed"
attribute when defining new rules.

Closes bazelbuild#8145.

PiperOrigin-RevId: 245405049
@laurentlb laurentlb mentioned this issue May 23, 2019
Closed
katre added a commit to katre/bazel that referenced this issue May 24, 2019
@katre
Allow Starlark rules to be able to use the exec_compatible_with
8c300a0 
attribute by default.

Fixes bazelbuild#8451, part of bazelbuild#8134.
@katre katre mentioned this issue May 24, 2019
Closed
bazel-io pushed a commit that referenced this issue May 24, 2019
@katre
Allow Starlark rules to be able to use the exec_compatible_with
35dd05a 
attribute by default.

Fixes #8451, part of #8134.

Closes #8453.

PiperOrigin-RevId: 249804440
aehlig pushed a commit that referenced this issue May 24, 2019
@katre @aehlig
Allow Starlark rules to be able to use the exec_compatible_with
3586a34 
attribute by default.

Fixes #8451, part of #8134.

Closes #8453.

PiperOrigin-RevId: 249804440
irengrig pushed a commit to irengrig/bazel that referenced this issue Jun 18, 2019
@katre @irengrig
Allow Starlark rules to be able to use the exec_compatible_with
ffac7e7 
attribute by default.

Fixes bazelbuild#8451, part of bazelbuild#8134.

Closes bazelbuild#8453.

PiperOrigin-RevId: 249804440
irengrig pushed a commit to irengrig/bazel that referenced this issue Jul 15, 2019
@katre @irengrig
Allow Starlark rules to be able to use the exec_compatible_with
3b8cc33 
attribute by default.

Fixes bazelbuild#8451, part of bazelbuild#8134.

Closes bazelbuild#8453.

PiperOrigin-RevId: 249804440
katre added a commit to katre/bazel that referenced this issue Nov 4, 2019
@katre
Remove the deprecated option
9dace66 
`--incompatible_disallow_rule_execution_platform_constraints_allowed`
and the associated Starlark code.

Part of bazelbuild#8134. Next PR will remove the actual underlying RuleClass enum
and functionality.
@katre katre mentioned this issue Nov 4, 2019
Closed
katre added a commit to katre/bazel that referenced this issue Nov 6, 2019
@katre
Remove the deprecated option
e4eadec 
`--incompatible_disallow_rule_execution_platform_constraints_allowed`
and the associated Starlark code.

Part of bazelbuild#8134. Next PR will remove the actual underlying RuleClass enum
and functionality.

Closes bazelbuild#10163.

PiperOrigin-RevId: 278911121
katre added a commit to katre/bazel that referenced this issue Nov 6, 2019
@katre
Remove the ExecutionPlatformConstraintsAllowed enum entirely.
aa213e3 
Fixes bazelbuild#8134.
@katre katre mentioned this issue Nov 6, 2019
Closed
irengrig pushed a commit to irengrig/bazel that referenced this issue Nov 7, 2019
@katre @irengrig
Remove the deprecated option
4028a48 
`--incompatible_disallow_rule_execution_platform_constraints_allowed`
and the associated Starlark code.

Part of bazelbuild#8134. Next PR will remove the actual underlying RuleClass enum
and functionality.

Closes bazelbuild#10163.

PiperOrigin-RevId: 278911121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katre katre

Labels
P2 We'll consider working on this in future. (Assignee optional) team-Configurability Issues for Configurability team type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the ExecutionPlatformConstraintsAllowed enum entirely. katre/bazel
1 participant
@katre