Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible_disallow_rule_execution_platform_constraints_allowed: Disallow the execution_platform_constraints_allowed attribute to rule #8136

Open
katre opened this issue Apr 24, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@katre
Copy link
Member

commented Apr 24, 2019

As part of #8134, we need to remove the execution_platform_constraints_allowed attribute to Starlark's rule() function. After the attribute is removed, all targets will be able to use exec_compatible_with to add restrictions on the execution platform.

Migration

Remove any existing uses of execution_platform_constraints_allowed from rules. All rules will be able to use execution_platform_constraints.

Timeline

Flag added: Bazel 0.26
Flag flipped: Bazel 0.27 (expected)

@katre katre self-assigned this Apr 24, 2019

@katre katre changed the title incompatible_disable_rule_execution_platform_constraints_allowed: Disable the execution_platform_constraints_allowed attribute to rule incompatible_disallow_rule_execution_platform_constraints_allowed: Disallow the execution_platform_constraints_allowed attribute to rule Apr 25, 2019

katre added a commit to katre/bazel that referenced this issue Apr 25, 2019

Add incompatible_disallow_rule_execution_platform_constraints_allowed
flag.

Part of bazelbuild#8136 and bazelbuild#8134.

RELNOTES: Adds
incompatible_disallow_rule_execution_platform_constraints_allowed, which
disallows the use of the "execution_platform_constraints_allowed"
attribute when defining new rules.

katre added a commit to katre/bazel that referenced this issue Apr 26, 2019

Add incompatible_disallow_rule_execution_platform_constraints_allowed…
… flag.

Part of bazelbuild#8136 and bazelbuild#8134.

RELNOTES: Adds
incompatible_disallow_rule_execution_platform_constraints_allowed, which
disallows the use of the "execution_platform_constraints_allowed"
attribute when defining new rules.

Closes bazelbuild#8145.

PiperOrigin-RevId: 245405049
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.