Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.29 - August 2019 (stable) #8572

Closed
dslomov opened this issue Jun 6, 2019 · 106 comments
Closed

Release 0.29 - August 2019 (stable) #8572

dslomov opened this issue Jun 6, 2019 · 106 comments
Assignees
@katre
Labels
release

Comments

@dslomov
Copy link
Contributor

dslomov commented Jun 6, 2019 •
edited
Loading

Target RC date - August 1st, 2019.
This release will have no breaking changes.

See the blog post for some details
@dslomov dslomov added the release label Jun 6, 2019
@dslomov dslomov changed the title Release 0.29 - August 2019 Release 0.29 - August 2019 (stable) Jun 6, 2019
@laszlocsomor laszlocsomor pinned this issue Jun 27, 2019
@dslomov dslomov mentioned this issue Jul 1, 2019
Closed
@dslomov dslomov unpinned this issue Jul 1, 2019
@laurentlb laurentlb pinned this issue Jul 24, 2019
@or-shachar
Copy link
Contributor

Is there a release candidate available?

@jin
Copy link
Member

jin commented Jul 29, 2019

@or-shachar the target RC date is in August.

@katre
Copy link
Member

katre commented Jul 29, 2019

@or-shachar I plan to cut the release on Thursday morning (NYC time).

@lberki
Copy link
Contributor

lberki commented Jul 30, 2019

#6790, deemed a requirement for Bazel 1.0, requires an incompatible flag that has not been submitted yet.

@scentini @katre please make sure the release is cut after the flag lands.

@lberki
Copy link
Contributor

lberki commented Jul 30, 2019

#9006, deemed a requirement for Bazel 1.0, requires an incompatible flag that has not been submitted yet (but is under review!)

@brandjon @katre please make sure the release is cut after the flag lands.

@dslomov
Copy link
Contributor Author

dslomov commented Jul 30, 2019

Let's postpone the cut until we have clarity on platform situation.

@dslomov
Copy link
Contributor Author

dslomov commented Aug 1, 2019 •
edited by brandjon
Loading

Re platforms: we decided to make no changes to platforms that need to get in 0.29
What is the status of #6790? /cc @scentini @lberki
What is the status of #9006? /cc @brandjon @lberki

@brandjon
Copy link
Member

brandjon commented Aug 1, 2019

#9006 is blocked on #9019, which is progressing well. It looks like it just needs to be broken up into multiple PRs (for third_party/ workflow reasons). If there aren't any surprises it'll be submitted today.

@katre
Copy link
Member

katre commented Aug 1, 2019

At this point waiting for tomorrow (August 2) before cutting the release.

@scentini and @dslomov, please let me know whether I need to wait for #6790, or just cherrypick the fix later.

@brandjon
Copy link
Member

brandjon commented Aug 1, 2019

The third_party/ submit dance for #9006 has concluded and the incompatible flag has been added. I've marked that issue migration-ready.

@lberki
Copy link
Contributor

lberki commented Aug 2, 2019

As per our discussion the day before yesterday, #6790 won't make it into 1.0 (right, @scentini ?)

@scentini
Copy link
Contributor

scentini commented Aug 2, 2019

Yes, #6790 won't make it into 1.0.

@katre
Copy link
Member

katre commented Aug 2, 2019

Evaluating 2d5b9f3 as a possible baseline: I've started a test run to validate it while I start checking over issues.

@katre
Copy link
Member

katre commented Aug 2, 2019

Test run with 2d5b9f3 as baseline is good: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1117

I am starting the release.

$ scripts/release/release.sh create --force_rc=1 0.29.0 2d5b9f35a859bbeec4df66fc6c2256db299dd56a

@katre
Copy link
Member

katre commented Aug 2, 2019

And the build has failed with python errors building the deb: https://buildkite.com/bazel-trusted/bazel-release/builds/86#5b8ae185-9cb4-46e6-b67e-223b5ea67ce3

Also, Windows has failed with errors creating the MSI: https://buildkite.com/bazel-trusted/bazel-release/builds/86#661817f8-ae61-485b-8869-e06f278d71f7

This was referenced Aug 2, 2019
Merged
Merged
@katre
Copy link
Member

katre commented Aug 2, 2019

I have fixes ready, waiting on bazelbuild/continuous-integration#783 and bazelbuild/continuous-integration#785

@katre
Copy link
Member

katre commented Aug 2, 2019

Trying again. Since 2d5b9f3 is being reverted internally, baseline is now 6c5ef53.

$ scripts/release/release.sh create --force_rc=2 0.29.0 6c5ef5369a3ffceb8a65cc159a2fff1401242810

@katre
Copy link
Member

katre commented Aug 2, 2019

Draft release notes are available for editing.

@katre
Copy link
Member

katre commented Aug 2, 2019

RC2 is available: https://releases.bazel.build/0.29.0/rc2/index.html

@ghost
Copy link

ghost commented Aug 3, 2019 •
edited by ghost
Loading

I feel 0.29 absolutely needs #9008 (or some other fix for the same underlying issue). Since 0.26, a single HTTP connection timeout when fetching artifacts terminates the build. (Bazel stopped retrying fetch attempts.)

@artem-zinnatullin
Copy link
Contributor

To add to @beasleyr-vmw's comment, #9015 is equally if not more important as it actually makes Bazel to use alternative url(s) as fallback(s).

@meteorcloudy
Copy link
Member

Please waiting for a fix for #9222

@meteorcloudy
Copy link
Member

@katre Please cherry-pick 644060b to fix #9222 , thanks!

@aehlig
Copy link
Contributor

aehlig commented Aug 22, 2019 via email

@dslomov
Copy link
Contributor Author

dslomov commented Aug 22, 2019

So we should close bazelbuild/rules_swift#288 as not need thanks to the rollback?

Is this change going to happen again? Any docs on what it will be some rule teams can read up/understand it in advance?

The change will now be guarded under --incompatible_generated_protos_in_virtual_imports that we expect to flip in the next release. Please follow up on #9215 if migration steps are not clear.

@katre
Copy link
Member

katre commented Aug 22, 2019 •
edited
Loading

Waiting for https://bazel-review.googlesource.com/c/bazel/+/111374/ before I create RC8.

@steeve
Copy link
Contributor

steeve commented Aug 22, 2019 •
edited
Loading

@thomasvl the PR should be safe to apply wether or not the flag is flipped, and I can confirm it's working (currently using rc6 atm, can't test on rc7 because of rules_go breakage)

bazel-io pushed a commit that referenced this issue Aug 23, 2019
@aehlig
repository mapping lookup: convert to canonical name first
76ed014 
By the way we propagate the information in which repository we are in,
we always have a repository name that is valid in the main repository;
however, it is not necessarily a canonical name. Our map of the repository
mappings, however, is keyed by canonical names. So, add the missing indirection
and first look up the canonical name for the repository name we're given
by looking it up in the mapping of the main repository (for which we know
its canonical name) and only then use that name as key.

Fixes a bug related to #7130.
Prerequisite to flip --incompatible_remap_main_repo.
Therefore, consider for Bazel 0.29.0 (#8572).

Change-Id: Icd426a18aaa406b614f4948a8122177463a72959
PiperOrigin-RevId: 265012106
@aehlig
Copy link
Contributor

aehlig commented Aug 23, 2019

Waiting for https://bazel-review.googlesource.com/c/bazel/+/111374/ before I create RC8.

https://bazel-review.googlesource.com/c/bazel/+/111374/ has been submitted as 76ed014.

katre pushed a commit that referenced this issue Aug 23, 2019
@aehlig @katre
repository mapping lookup: convert to canonical name first
f03da5c 
By the way we propagate the information in which repository we are in,
we always have a repository name that is valid in the main repository;
however, it is not necessarily a canonical name. Our map of the repository
mappings, however, is keyed by canonical names. So, add the missing indirection
and first look up the canonical name for the repository name we're given
by looking it up in the mapping of the main repository (for which we know
its canonical name) and only then use that name as key.

Fixes a bug related to #7130.
Prerequisite to flip --incompatible_remap_main_repo.
Therefore, consider for Bazel 0.29.0 (#8572).

Change-Id: Icd426a18aaa406b614f4948a8122177463a72959
PiperOrigin-RevId: 265012106
@katre
Copy link
Member

katre commented Aug 23, 2019

Created RC8:

$ scripts/release/release.sh create --force_rc=8 0.29.0 a4e7a7a5235f415eea5515b49121ec79a95b78ad 644060b7a4bc98384b66e3d2343b950b875b5e35 067040d7bcb3b24a88432e210a96adacee3f37b4 76ed014e77d7b862f6eb2894600ae525ea570f11

Waiting for tests to complete the release process.

Assuming no new issues, this needs to bake until next Tuesday (August 27) before it can be released.

@katre
Copy link
Member

katre commented Aug 23, 2019

RC8 is available for testing: https://releases.bazel.build/0.29.0/rc8/index.html

Downstream tests are running: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1159

@katre
Copy link
Member

katre commented Aug 23, 2019

Downstream tests all pass.

@katre
Copy link
Member

katre commented Aug 27, 2019

Barring any last minute release blockers, I plan to finish the release of 0.29.0 later today.

@katre
Copy link
Member

katre commented Aug 27, 2019

Still working to finalize the release announcement: at this point the release is probably tomorrow.

@katre
Copy link
Member

katre commented Aug 28, 2019

Starting the release.

@katre
Copy link
Member

katre commented Aug 28, 2019

The release has now been pushed to https://github.com/bazelbuild/bazel/releases/tag/0.29.0

@vbatts, @petemounce, and @excitoon, can you please update your builds?

@katre
Copy link
Member

katre commented Aug 28, 2019

The blog post is available, and docs should be propagating shortly.

@vbatts
Copy link

vbatts commented Aug 28, 2019 via email

@iirina iirina mentioned this issue Aug 29, 2019
Closed
@v-mr v-mr mentioned this issue Aug 29, 2019
Closed
@jmillikin-stripe
Copy link
Contributor

While upgrading a build from 0.27 to 0.29, I discovered there was a regression in v0.28 for git_repository pulling at a tagged commit. The fix is merged in #9059, would it be possible to cherry-pick this into v0.29.1 ?

@petemounce
Copy link
Contributor

Pushed to chocolatey.

@katre
Copy link
Member

katre commented Aug 30, 2019

@jmillikin-stripe Please open an issue and assign it to me so I can track fixing the regression.

@katre katre mentioned this issue Aug 30, 2019
Closed
@katre
Copy link
Member

katre commented Aug 30, 2019

Filed #9293 to track the 0.29.1 point release: since 0.29.0 is finished I am closing this issue.

@katre katre closed this as completed Aug 30, 2019
@laszlocsomor
Copy link
Contributor

Thanks @petemounce !

@katre katre unpinned this issue Aug 30, 2019
@dslomov dslomov pinned this issue Sep 2, 2019
@buchgr buchgr unpinned this issue Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katre katre

Labels
release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests