Fix git_repository rule to support fetching a commit on a tag #9059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
irengrig
commented
Aug 2, 2019
irengrig
commented
- specified commit may only be present on a tag, not on any branch
- use the verbose references specification in git fetch command
- add black box test
- initially implemented by https://github.com/jamiesnape in git_worker.bzl: also fetch all tags #8933, but the suggested solution with --tags flag does not work for CentOS Bazel CI configuration
- specified commit may only be present on a tag, not on any branch - use the verbose references specification in git fetch command - add black box test - initially implemented by https://github.com/jamiesnape in bazelbuild#8933, but the suggested solution with --tags flag does not work for CentOS Bazel CI configuration
This was referenced Aug 30, 2019
katre
pushed a commit
that referenced
this pull request
Sep 3, 2019
- specified commit may only be present on a tag, not on any branch - use the verbose references specification in git fetch command - add black box test - initially implemented by https://github.com/jamiesnape in #8933, but the suggested solution with --tags flag does not work for CentOS Bazel CI configuration Closes #9059. PiperOrigin-RevId: 261316448
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.