Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose JavaInfo on java proto aspects #9162

Closed
iirina opened this issue Aug 13, 2019 · 5 comments
Closed

Expose JavaInfo on java proto aspects #9162

iirina opened this issue Aug 13, 2019 · 5 comments
Assignees
@iirina
Labels
team-Rules-Java Issues for Java rules

Comments

@iirina
Copy link
Contributor

iirina commented Aug 13, 2019 •
edited
Loading

The JavaInfo provider is exposed on all the java rules except on java proto aspects.
This blocks the migration for --incompatible_disallow_legacy_java_provider for projects using aspects on aspects over java proto targets (e.g. intellij plugin).
@iirina
Copy link
Contributor Author

iirina commented Aug 13, 2019

This was fixed by ef8b6f6.

@iirina iirina self-assigned this Aug 13, 2019
@iirina iirina added the team-Rules-Java Issues for Java rules label Aug 13, 2019
@katre
Copy link
Member

katre commented Aug 13, 2019

Will cherrypick this fix into 0.29.0: #8572.

@lberki
Copy link
Contributor

lberki commented Aug 14, 2019

ef8b6f6 is the fix to be cherry-picked, isn't it?

@iirina
Copy link
Contributor Author

iirina commented Aug 14, 2019

@lberki yes, @katre already cherry picked it in rc6

@lberki
Copy link
Contributor

lberki commented Aug 14, 2019

Oh, ok. Then I'm not up-to-date enough :) Should we close this bug then?

@iirina iirina closed this as completed Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iirina iirina

Labels
team-Rules-Java Issues for Java rules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@katre @iirina @lberki