Rename UnloadedToolchainContextKey to ToolchainContextKey. #11336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup leading to toolchain transitions, bazelbuild#10523.
juliexxia
reviewed
May 11, 2020
| @@ -485,11 +485,11 @@ public SkyValue compute(SkyKey key, Environment env) throws ConfiguredTargetFunc | |||
| configuration.getFragmentsMap().keySet(), | |||
| BuildOptions.diffForReconstruction(defaultBuildOptions, toolchainOptions)); | |||
|
|
|||
| Map<String, UnloadedToolchainContextKey> unloadedToolchainContextKeys = new HashMap<>(); | |||
| Map<String, ToolchainContextKey> unloadedToolchainContextKeys = new HashMap<>(); | |||
There was a problem hiding this comment.
Should these relevant var names be changed to, e.g., toolchainContextKeys? Does UnloadedToolchainContext still exist? Sorry if I'm missing context!
There was a problem hiding this comment.
UnloadedToolchainContext still exists, but yes, these should be renamed.
| @@ -501,19 +501,19 @@ public RuleContext getRuleContextForTesting( | |||
| SkyFunctionEnvironmentForTesting skyfunctionEnvironment = | |||
| skyframeExecutor.getSkyFunctionEnvironmentForTesting(eventHandler); | |||
|
|
|||
| Map<String, UnloadedToolchainContextKey> unloadedToolchainContextKeys = new HashMap<>(); | |||
| Map<String, ToolchainContextKey> unloadedToolchainContextKeys = new HashMap<>(); | |||
There was a problem hiding this comment.
same renaming comment here and below
juliexxia
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup leading to toolchain transitions, #10523.