Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement namespaced R classes #11385

Closed
wants to merge 2 commits into from

Conversation

jongerrish
Copy link
Contributor

Enable rudimentary R class namespacing where each library only contains
references to the resources it declares instead of declarations plus all
transitive dependency references.

This basically implements the android.namespacedRClass=true Gradle feature in Bazel.

For our build this saves a total of 215MB outputs + 145 Actions for a clean build in addition to previous open PRs.

No resource merging for android_library targets
Smaller R.{class,txt}
Less desugaring + dexing

@jongerrish
Copy link
Contributor Author

@jin

@jin
Copy link
Member

jin commented May 14, 2020

cc @donaldchai @timpeut @djwhang

@ulfjack
Copy link
Contributor

ulfjack commented Jun 3, 2020

Not much progress here. Anyone willing to make a decision here? If Google isn't using these rules internally, maybe someone from the community can take over responsibility for reviews (but would require a Googler to merge)?

@Bencodes
Copy link
Contributor

It's been a while since there have been any updates here. Could someone make a call here?

@nkoroste
Copy link
Contributor

Any updates on this?

@ahumesky
Copy link
Contributor

ahumesky commented Oct 9, 2023

Closing this one in favor of the Starlark version of this issue: bazelbuild/rules_android#66

@ahumesky ahumesky closed this Oct 9, 2023
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes team-Android Issues for Android team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants