Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take no action to prefetch empty artifacts. #12514

Closed
wants to merge 1 commit into from
Closed

Take no action to prefetch empty artifacts. #12514

wants to merge 1 commit into from

Conversation

benjaminp
Copy link
Collaborator

@benjaminp benjaminp commented Nov 18, 2020 •
edited

Previously, Bazel would attempt to overwrite /dev/null.

@google-cla google-cla bot added the cla: yes label Nov 18, 2020
@benjaminp benjaminp mentioned this pull request Nov 19, 2020
Closed
@benjaminp
Take no action to prefetch empty artifacts.
e3e579a 
Previously, Bazel would attempt to overwrite /dev/null.
@coeuvre coeuvre self-requested a review November 20, 2020 02:58
@coeuvre coeuvre self-assigned this Nov 20, 2020
@coeuvre coeuvre added the team-Remote-Exec Issues and PRs for the Execution (Remote) team label Nov 20, 2020
@coeuvre
Copy link
Member

coeuvre commented Nov 20, 2020

@ulfjack This might fix the issue ERROR: /home/ulfjack/Google/tensorflow/tensorflow/core/util/BUILD:364:24: Action tensorflow/core/util/version_info.cc failed: Exec failed due to IOException: /dev/null.remote (Permission denied) #11782 (comment)

coeuvre
coeuvre approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@coeuvre coeuvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Importing.

@bazel-io bazel-io closed this in a87d7ed Nov 23, 2020
@benjaminp benjaminp deleted the prefetch-empty branch November 23, 2020 14:09
@ulfjack
Copy link
Contributor

ulfjack commented Dec 15, 2020

Thanks! It does resolve the IOException I've been seeing.

meisterT pushed a commit that referenced this pull request Dec 15, 2020
@benjaminp @meisterT
Take no action to prefetch empty artifacts.
51e9d36 
Previously, Bazel would attempt to overwrite /dev/null.

Closes #12514.

PiperOrigin-RevId: 343824719
ulfjack pushed a commit to EngFlow/bazel that referenced this pull request Mar 5, 2021
@benjaminp @ulfjack
Take no action to prefetch empty artifacts.
de8f8e8 
Previously, Bazel would attempt to overwrite /dev/null.

Closes bazelbuild#12514.

PiperOrigin-RevId: 343824719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coeuvre coeuvre coeuvre approved these changes

Assignees

@coeuvre coeuvre

Labels
cla: yes team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benjaminp @coeuvre @ulfjack