-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent --repo_env from triggering unnecessary fetches #13126
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@philwo , any thoughts on this? |
Wyverald
approved these changes
Mar 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll import it now.
meteorcloudy
reviewed
Mar 9, 2021
It looks like `--repo_env` entries get added to every repository rule's marker data. That is regardless of whether the repository rule declared that it uses the environment variable. This causes unnecessary fetches of the external repositories. This patch aims to fix that by making repository rules only depend on `--repo_env` values that they specify in their `environ` attributes.
55bed66
to
7f23478
Compare
philwo
pushed a commit
that referenced
this pull request
Mar 15, 2021
It looks like `--repo_env` entries get added to every repository rule's marker data. That is regardless of whether the repository rule declared that it uses the environment variable. This causes unnecessary fetches of the external repositories. This patch aims to fix that by making repository rules only depend on `--repo_env` values that they specify in their `environ` attributes. I also took this opportunity to fix up all instances of `bazel-genfiles` in `starlark_repository_test.sh` to `bazel-bin`. Closes #13126. PiperOrigin-RevId: 361813865
philwo
pushed a commit
that referenced
this pull request
Mar 15, 2021
It looks like `--repo_env` entries get added to every repository rule's marker data. That is regardless of whether the repository rule declared that it uses the environment variable. This causes unnecessary fetches of the external repositories. This patch aims to fix that by making repository rules only depend on `--repo_env` values that they specify in their `environ` attributes. I also took this opportunity to fix up all instances of `bazel-genfiles` in `starlark_repository_test.sh` to `bazel-bin`. Closes #13126. PiperOrigin-RevId: 361813865
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
--repo_env
entries get added to every repositoryrule's marker data. That is regardless of whether the repository rule
declared that it uses the environment variable. This causes
unnecessary fetches of the external repositories.
This patch aims to fix that by making repository rules only depend on
--repo_env
values that they specify in theirenviron
attributes.I also took this opportunity to fix up all instances of
bazel-genfiles
in
starlark_repository_test.sh
tobazel-bin
.