Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop redundant ErrorProneTimings shim from ErrorPronePlugin #15504

Closed
wants to merge 1 commit into from
Closed

Drop redundant ErrorProneTimings shim from ErrorPronePlugin #15504

wants to merge 1 commit into from

Conversation

hisener
Copy link
Contributor

@hisener hisener commented May 15, 2022

Since the used Error Prone version is 2.3.4+, ErrorProneTimings shim in ErrorPronePlugin.java is redundant. This change drops it.

cc @cushon

@hisener hisener requested a review from a team as a code owner May 15, 2022 10:28
@sgowroji sgowroji added team-Rules-Java Issues for Java rules awaiting-review PR is awaiting review from an assigned reviewer labels May 16, 2022
@bazel-io bazel-io closed this in bbf74d5 May 16, 2022
@hisener hisener deleted the halil.sener/drop-ep-timings-shim branch May 16, 2022 17:04
@ShreeM01 ShreeM01 removed the awaiting-review PR is awaiting review from an assigned reviewer label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
team-Rules-Java Issues for Java rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hisener @sgowroji @ShreeM01