Fail the build on repository rule errors in a module extension #15796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
bzlmod-fail-module-extensions
branch
from
e1bf4a4
to
eac799d
Compare
fmeum
changed the title
sgowroji
added
team-ExternalDeps
meteorcloudy
added
awaiting-PR-merge
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 5.3.0 |
bazel-io
removed
the
potential release blocker
Wyverald
approved these changes
Jul 4, 2022
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/BzlmodRepoRuleCreator.java
Outdated
Show resolved
Hide resolved
Also emit a Starlark stack trace pointing to the particular call site of the repository rule. Previously, the root cause error would be printed, but the build would continue. Fixes bazelbuild#14526 (comment)
fmeum
force-pushed
the
bzlmod-fail-module-extensions
branch
from
eac799d
to
7db6ea1
Compare
Wyverald
approved these changes
Jul 4, 2022
sgowroji
removed
the
awaiting-PR-merge
sgowroji
pushed a commit
to sgowroji/bazel
that referenced
this pull request
Jul 14, 2022
Fail the build on repository rule errors in a module extension Also emit a Starlark stack trace pointing to the particular call site of the repository rule. Previously, the root cause error would be printed, but the build would continue. Fixes bazelbuild#14526 (comment) Closes bazelbuild#15796. PiperOrigin-RevId: 459065865 Change-Id: I2444378c7857b1031fabfacd00f8246583bb2146
|
Hey @fmeum , we are trying to cherry-pick these changes to release-5.3.0. But pre-submit checks are failing due to missing dependencies. So, could you please help us in cherry picking these changes to release-5.3.0? |
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Jul 20, 2022
Fail the build on repository rule errors in a module extension Also emit a Starlark stack trace pointing to the particular call site of the repository rule. Previously, the root cause error would be printed, but the build would continue. Fixes bazelbuild#14526 (comment) Closes bazelbuild#15796. PiperOrigin-RevId: 459065865 Change-Id: I2444378c7857b1031fabfacd00f8246583bb2146
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Jul 20, 2022
Fail the build on repository rule errors in a module extension Also emit a Starlark stack trace pointing to the particular call site of the repository rule. Previously, the root cause error would be printed, but the build would continue. Fixes bazelbuild#14526 (comment) Closes bazelbuild#15796. PiperOrigin-RevId: 459065865 Change-Id: I2444378c7857b1031fabfacd00f8246583bb2146
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Jul 20, 2022
Fail the build on repository rule errors in a module extension Also emit a Starlark stack trace pointing to the particular call site of the repository rule. Previously, the root cause error would be printed, but the build would continue. Fixes bazelbuild#14526 (comment) Closes bazelbuild#15796. PiperOrigin-RevId: 459065865 Change-Id: I2444378c7857b1031fabfacd00f8246583bb2146
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail the build on repository rule errors in a module extension
Also emit a Starlark stack trace pointing to the particular call site
of the repository rule.
Previously, the root cause error would be printed, but the build would
continue.
Fixes #14526 (comment)