Fail the build on repository rule errors in a module extension #15926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
release-5.3.0-15796
branch
from
afce42c
to
3ea0f18
Compare
Fail the build on repository rule errors in a module extension Also emit a Starlark stack trace pointing to the particular call site of the repository rule. Previously, the root cause error would be printed, but the build would continue. Fixes bazelbuild#14526 (comment) Closes bazelbuild#15796. PiperOrigin-RevId: 459065865 Change-Id: I2444378c7857b1031fabfacd00f8246583bb2146
fmeum
force-pushed
the
release-5.3.0-15796
branch
from
3ea0f18
to
1e271ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail the build on repository rule errors in a module extension
Also emit a Starlark stack trace pointing to the particular call site
of the repository rule.
Previously, the root cause error would be printed, but the build would
continue.
Fixes #14526 (comment)
Closes #15796.
PiperOrigin-RevId: 459065865
Change-Id: I2444378c7857b1031fabfacd00f8246583bb2146
Closes #15802