Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue that `incompatible_remote_build_event_upload_respect_no_… #16045

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Fix an issue that `incompatible_remote_build_event_upload_respect_no_… #16045

merged 2 commits into from
Aug 4, 2022

Commits on Aug 4, 2022

  1. Fix an issue that `incompatible_remote_build_event_upload_respect_no_… 

    …cache` doesn't work with BwtB.

The root cause is we use `Path` as key to check which files are omitted, but it also compares the underlying filesystem. When BwtB is enabled, the filesystem for the file is different so we failed to mark the file as omitted.

This change fixes that by using `PathFragment` as key.

Fixes bazelbuild#15527.

Closes bazelbuild#16023.

PiperOrigin-RevId: 465284879
Change-Id: I49bbd7a6055e0f234b4ac86a224886bd85797f71
    @coeuvre @sgowroji
    coeuvre authored and sgowroji committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    c6da186 View commit details
    Browse the repository at this point in the history

  2. Update ByteStreamBuildEventArtifactUploader changes 

    Removing the import as it is throwing the error
    @sgowroji
    sgowroji authored Aug 4, 2022
    Configuration menu
    Copy the full SHA
    445d5e7 View commit details
    Browse the repository at this point in the history