Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3.1] add change to allow blaze info to skip Starlark build settings that start with --no prefix #16258

Merged
merged 1 commit into from Sep 13, 2022

Conversation

ghost
Copy link

@ghost ghost commented Sep 12, 2022

Resolves #16257 .

… start with --no prefix

* add unit tests for both info and clean commands

PiperOrigin-RevId: 424863510
@ghost ghost requested a review from ShreeM01 as a code owner September 12, 2022 23:51
@google-cla
Copy link

google-cla bot commented Sep 12, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ghost
Copy link
Author

ghost commented Sep 12, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Bah. I signed the CLA and have had PRs merged before. However, this was a backport/cherry-pick of a commit that originated from Google. I left the original authorship as-is because I didn't author the code. What is the best way to proceed?

@ShreeM01 ShreeM01 added team-Configurability platforms, toolchains, cquery, select(), config transitions awaiting-user-response Awaiting a response from the author and removed team-Configurability platforms, toolchains, cquery, select(), config transitions awaiting-user-response Awaiting a response from the author labels Sep 13, 2022
@sgowroji
Copy link
Member

Hello @beasleyr-vmw, Could you please rescan and verify the CLA on this PR and share for final review. Thanks!

@sgowroji sgowroji added team-Configurability platforms, toolchains, cquery, select(), config transitions awaiting-user-response Awaiting a response from the author labels Sep 13, 2022
@fmeum
Copy link
Collaborator

fmeum commented Sep 13, 2022

@sgowroji The problem here is that the commit is cherry-picked from a Googler's commit and thus uses their author email, which is what the CLA bot checks against. But of course the googler hasn't signed the CLA. What is the best course of action in this case?

@sgowroji sgowroji added awaiting-review PR is awaiting review from an assigned reviewer and removed awaiting-user-response Awaiting a response from the author labels Sep 13, 2022
@Wyverald
Copy link
Member

The CLA check has been overridden by "a googler" (don't know who did that). So this should be good to go.

@ShreeM01 ShreeM01 merged commit ceed7f1 into bazelbuild:release-5.3.1 Sep 13, 2022
@ShreeM01 ShreeM01 removed the awaiting-review PR is awaiting review from an assigned reviewer label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants