Fix --host_features with multiple transitions #17625
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShreeM01
added
team-Rules-CPP
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
bazel-io
removed
the
potential release blocker
|
Hi @keith @brentleyjones we're actually planning to do the final release for 6.1 tomorrow so won't be able to include this fix. |
|
Hmm, can it be included in that cut? |
keertk
added
potential release blocker
|
Ok, we'll create a new release candidate today/tomorrow and include this one. |
Wyverald
approved these changes
Mar 1, 2023
keertk
added
awaiting-PR-merge
|
As far as I'm concerned this can make a future 6.x release instead of delaying this one. Especially since it's off by default and this bug is an edge case |
|
We've had a release with changes that weren't in an RC first. That's all I'm recommending for this very small change. I don't think it needs another RC. |
ShreeM01
removed
the
awaiting-PR-merge
keertk
added a commit
that referenced
this pull request
Mar 1, 2023
* Fix --host_features with multiple transitions Fixes #13839 (comment) Closes #17625. PiperOrigin-RevId: 513249316 Change-Id: Ied4ab6958febaf320ae9e0f906c8071db0077e43 * Update exec to host --------- Co-authored-by: Keith Smiley <keithbsmiley@gmail.com> Co-authored-by: keertk <110264242+keertk@users.noreply.github.com>
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
Fixes bazelbuild#13839 (comment) Closes bazelbuild#17625. PiperOrigin-RevId: 513249316 Change-Id: Ied4ab6958febaf320ae9e0f906c8071db0077e43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13839 (comment)