Make rules_testing available for Bazel tests #18182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
1920-add-rules-testing
branch
2 times, most recently
from
e5128b9
to
e8c8bd8
Compare
|
@rickeylev Could you review this PR? FYI @oquenchil |
github-actions
bot
added
the
awaiting-review
rickeylev
requested changes
Apr 23, 2023
fmeum
force-pushed
the
1920-add-rules-testing
branch
from
e8c8bd8
to
ed6acb7
Compare
Includes an update of bazel_skylib to the latest version 1.4.1 as the (very old) version 1.0.3 wasn't compatible with rules_testing.
fmeum
force-pushed
the
1920-add-rules-testing
branch
from
ed6acb7
to
38f6b3f
Compare
rickeylev
approved these changes
Apr 24, 2023
rickeylev
added
awaiting-PR-merge
|
/cc @comius as fyi; I unlikely have approval for these code paths internally, so I'll send it to him |
sgowroji
removed
the
awaiting-PR-merge
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
Includes an update of bazel_skylib to 1.3.0 as the (very old) version 1.0.3 wasn't compatible with rules_testing. Work towards bazelbuild#1920 Closes bazelbuild#18182. PiperOrigin-RevId: 527021012 Change-Id: I80ebff1a1aa656974ad6a1bb1809d8f919a2fa22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes an update of bazel_skylib to 1.3.0 as the (very old) version 1.0.3 wasn't compatible with rules_testing.
Work towards #1920