Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.3.1] Fix a bug where frozen targets list was mutated while expanding env attribute for cc_test #19052

Conversation

brentleyjones
Copy link
Contributor

@brentleyjones brentleyjones commented Jul 25, 2023

Resolves #19046.

Add a test covering the behavior.

PiperOrigin-RevId: 504294442
Change-Id: If9f96b631ca958e746613563c56103044c973277

(cherry picked from commit a63d8eb)

…ttribute

for cc_test.

Add a test covering the behavior.

PiperOrigin-RevId: 504294442
Change-Id: If9f96b631ca958e746613563c56103044c973277
(cherry picked from commit a63d8eb)
…ist-was-mutated-while-expanding-env-attribute
@keertk keertk merged commit 4ca3407 into release-6.3.1 Jul 25, 2023
28 checks passed
@brentleyjones brentleyjones deleted the bj/fix-a-bug-where-frozen-targets-list-was-mutated-while-expanding-env-attribute branch July 25, 2023 13:36
apattidb pushed a commit to databricks/bazel that referenced this pull request Jul 26, 2023
…ttribute (bazelbuild#19052)

for cc_test.

Add a test covering the behavior.

PiperOrigin-RevId: 504294442
Change-Id: If9f96b631ca958e746613563c56103044c973277
(cherry picked from commit a63d8eb)

Co-authored-by: Googler <gnish@google.com>
copybara-service bot pushed a commit that referenced this pull request Jul 31, 2023
Baseline:  0f231ac

Release Notes:

+ Mark isolated extension usages as experimental (#19050)
+ Fix a bug where frozen targets list was mutated while expanding env attribute (#19052)
+ Add documentation for --experimental_isolated_extension_usage (#19071)
+ Advertise CcInfo from cc_import (#19086)
+ Create .bazelversion to address postsubmit issues (#19089)
+ Update java_tools version to 12.6 (#19091)
+ Disable lockfiles by default (#19106)

Acknowledgements:

This release contains contributions from many people at Google, as well as Brentley Jones, Fabian Meumertzheim, oquenchil, Xùdōng Yáng.
apattidb pushed a commit to databricks/bazel that referenced this pull request Aug 3, 2023
Baseline:  0f231ac

Release Notes:

+ Mark isolated extension usages as experimental (bazelbuild#19050)
+ Fix a bug where frozen targets list was mutated while expanding env attribute (bazelbuild#19052)
+ Add documentation for --experimental_isolated_extension_usage (bazelbuild#19071)
+ Advertise CcInfo from cc_import (bazelbuild#19086)
+ Create .bazelversion to address postsubmit issues (bazelbuild#19089)
+ Update java_tools version to 12.6 (bazelbuild#19091)
+ Disable lockfiles by default (bazelbuild#19106)

Acknowledgements:

This release contains contributions from many people at Google, as well as Brentley Jones, Fabian Meumertzheim, oquenchil, Xùdōng Yáng.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants