Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.3.1] Disable lockfiles by default #19106

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

Wyverald
Copy link
Member

We're seeing too many lockfile issues in 6.3.0. Let's disable this in 6.3.1 so that we have time to properly fix them, and re-enable it in 6.4.0.

cc @meteorcloudy @SalmaSamy

We're seeing too many lockfile issues in 6.3.0. Let's disable this in 6.3.1 so that we have time to properly fix them, and re-enable it in 6.4.0.
@Wyverald
Copy link
Member Author

a bit more context: we've seen #19105 and #19068 pop up. The latter has a fix in flight but is unlikely to land until next week, and that's holding up 6.3.1 for too long. Merging this PR instead gives us more breathing room.

cc also @keertk

@keertk keertk enabled auto-merge (squash) July 27, 2023 20:11
@keertk keertk added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label Jul 27, 2023
@keertk keertk self-requested a review July 27, 2023 20:12
@keertk keertk merged commit 5de5d3b into release-6.3.1 Jul 27, 2023
27 of 28 checks passed
@Wyverald Wyverald deleted the wyv-disable-lockfiles branch July 27, 2023 21:21
copybara-service bot pushed a commit that referenced this pull request Jul 31, 2023
Baseline:  0f231ac

Release Notes:

+ Mark isolated extension usages as experimental (#19050)
+ Fix a bug where frozen targets list was mutated while expanding env attribute (#19052)
+ Add documentation for --experimental_isolated_extension_usage (#19071)
+ Advertise CcInfo from cc_import (#19086)
+ Create .bazelversion to address postsubmit issues (#19089)
+ Update java_tools version to 12.6 (#19091)
+ Disable lockfiles by default (#19106)

Acknowledgements:

This release contains contributions from many people at Google, as well as Brentley Jones, Fabian Meumertzheim, oquenchil, Xùdōng Yáng.
apattidb pushed a commit to databricks/bazel that referenced this pull request Aug 3, 2023
Baseline:  0f231ac

Release Notes:

+ Mark isolated extension usages as experimental (bazelbuild#19050)
+ Fix a bug where frozen targets list was mutated while expanding env attribute (bazelbuild#19052)
+ Add documentation for --experimental_isolated_extension_usage (bazelbuild#19071)
+ Advertise CcInfo from cc_import (bazelbuild#19086)
+ Create .bazelversion to address postsubmit issues (bazelbuild#19089)
+ Update java_tools version to 12.6 (bazelbuild#19091)
+ Disable lockfiles by default (bazelbuild#19106)

Acknowledgements:

This release contains contributions from many people at Google, as well as Brentley Jones, Fabian Meumertzheim, oquenchil, Xùdōng Yáng.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants