Include dependency edge info in transition errors #19251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
awaiting-review
|
@gregestren This was born out of the need to debug a failing transition created by a macro. Happy to change essentially anything about the error message, I just found that having "from target" and attribute in it. "to target" isn't really necessary information as the transition logic can't depend on it, so I'm happy to drop this if you find it confusing. |
When a Starlark transition implementation function fails, it now prints an error such as: ``` ERROR: /home/user/example/BUILD.bazel:3:11: On dependency edge //pkg:wrapper -|exports|-> //pkg:real_target: Errors encountered while applying Starlark transition ``` Previously, the generated error messages would only point to the BUILD file location of the target with the outgoing edge as well as a stack trace of the transition function (the latter only for Starlark errors, not those encountered during option conversion).
|
I honestly find having toTarget less confusing. While you're right that the transition logic doesn't use it, it it's natural to me to read a dependency edge as a |
gregestren
approved these changes
Aug 15, 2023
gregestren
added
awaiting-PR-merge
|
@gregestren I just noticed that this could be even more useful if it also included the configuration hash. Sorry for the approval invalidation, could you take another look? |
gregestren
approved these changes
Aug 15, 2023
github-actions
bot
removed
the
awaiting-PR-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Starlark transition implementation function fails, it now prints an error such as:
Previously, the generated error messages would only point to the BUILD file location of the target with the outgoing edge as well as a stack trace of the transition function (the latter only for Starlark errors, not those encountered during option conversion).