Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include dependency edge info in transition errors #19251

Closed
wants to merge 2 commits into from
Closed

Include dependency edge info in transition errors #19251

wants to merge 2 commits into from

Commits on Aug 15, 2023

  1. Include dependency edge info in transition errors 

    When a Starlark transition implementation function fails, it now prints
an error such as:

```
ERROR: /home/user/example/BUILD.bazel:3:11: On dependency edge //pkg:wrapper -|exports|-> //pkg:real_target: Errors encountered while applying Starlark transition
```

Previously, the generated error messages would only point to the BUILD
file location of the target with the outgoing edge as well as a stack
trace of the transition function (the latter only for Starlark errors,
not those encountered during option conversion).
    @fmeum
    fmeum committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    f9f4cbe View commit details
    Browse the repository at this point in the history

  2. Also include configuration hash

    @fmeum
    fmeum committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    19b169e View commit details
    Browse the repository at this point in the history