-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing issue 21741: Modifying reference documentation #23238
base: master
Are you sure you want to change the base?
Fixing issue 21741: Modifying reference documentation #23238
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving the docs!
@meteorcloudy Is this change safe to merge or does it need disambiguation so that it doesn't apply internally?
<pre><code class="lang-starlark"> | ||
const std::string path = devtools_build::GetDataDependencyFilepath( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be internal specific doc. /cc @comius
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pzembrod Can you help address this?
FWIW, from the perspective of someone working on a project that needs to straddle both external and internal universes, it would be nice if the patterns could align a bit better. Every divergence is one more bit of friction we have to deal with when updating things. |
e96dcf6
to
f9a9711
Compare
f9a9711
to
45eebf2
Compare
…azel_tools that provides runfiles.h
Fixes #21741
Changing the reference documentation. Fix was first tested in private project, based on the comments contained in runfiles_src.h. Related to comments of issue #11212.