Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix powershellv2 #2633

Closed
wants to merge 4 commits into from
Closed

Fix powershellv2 #2633

wants to merge 4 commits into from

Conversation

petemounce
Copy link
Contributor

@petemounce petemounce commented Mar 6, 2017

Powershell v2 (win7 vintage) doesn't have json cmdlets.

Got a report via chocolatey.org message that this doesn't work on win7. Cried. Replaced with simpler text file based approach for separating data from code.

Also fix package version fix notation bit of the automation to produce version numbers valid with chocolatey/nuspec.

I've already published a fixed 0.4.5-rc2 and 0.4.4 with this

Peter Mounce added 4 commits March 6, 2017 00:49
Got a report via chocolatey.org message that this doesn't work on win7. Cried. Replaced with simpler text file based approach for separating data from code.
@bazel-io
Copy link
Member

bazel-io commented Mar 6, 2017

Can one of the admins verify this patch?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@petemounce
Copy link
Contributor Author

@meteorcloudy @laszlocsomor ping? Bot still needs a kick ;)

@laszlocsomor
Copy link
Contributor

Thanks for this bugfix! I'm honestly not the best person to review PS code... Anyway, took a look, LGTM for what I can tell. Could you reply "I signed it!" to maybe nudge the bot? I know you did but let's try to convince the bot too :)

@petemounce
Copy link
Contributor Author

I signed it!

@petemounce
Copy link
Contributor Author

Or maybe it understands Klingon: qI' jIH!


Install-ChocolateyZipPackage -PackageName "$packageName" `
-Url "$($p.package.uri)" `
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way - these are removed because there's no 32-bit build. These not being present causes chocolatey to print a friendly error to a 32-bit user saying it's not possible to install this there.

@laszlocsomor
Copy link
Contributor

I think this looks good, will import now.

@petemounce
Copy link
Contributor Author

Cool; thanks :)

@bazel-io bazel-io closed this in ddcfc61 Mar 7, 2017
@petemounce petemounce deleted the fix_powershellv2 branch March 8, 2017 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants