-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix powershellv2 #2633
Fix powershellv2 #2633
Conversation
Got a report via chocolatey.org message that this doesn't work on win7. Cried. Replaced with simpler text file based approach for separating data from code.
Can one of the admins verify this patch? |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
@meteorcloudy @laszlocsomor ping? Bot still needs a kick ;) |
Thanks for this bugfix! I'm honestly not the best person to review PS code... Anyway, took a look, LGTM for what I can tell. Could you reply "I signed it!" to maybe nudge the bot? I know you did but let's try to convince the bot too :) |
I signed it! |
Or maybe it understands Klingon: |
|
||
Install-ChocolateyZipPackage -PackageName "$packageName" ` | ||
-Url "$($p.package.uri)" ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way - these are removed because there's no 32-bit build. These not being present causes chocolatey to print a friendly error to a 32-bit user saying it's not possible to install this there.
I think this looks good, will import now. |
Cool; thanks :) |
Powershell v2 (win7 vintage) doesn't have json cmdlets.
Got a report via chocolatey.org message that this doesn't work on win7. Cried. Replaced with simpler text file based approach for separating data from code.
Also fix package version fix notation bit of the automation to produce version numbers valid with chocolatey/nuspec.
I've already published a fixed 0.4.5-rc2 and 0.4.4 with this