[Skylark] Avoid unnecessary allocations. #5656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@c-parsons, this change helps with memory and CPU usage, since we don't have to allocate an intermediate |
Since this happens only every single Skylark method invocation CPU and memory usage quickly adds up and shows up on profiler samples a lot.
ttsugriy
force-pushed
the
append-extra-args
branch
from
d31c5c1
to
18141a1
Compare
ttsugriy
requested review from
brandjon,
c-parsons,
dkelmer,
dslomov,
laurentlb and
vladmos
as code owners
|
rebased and resolved conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this happens only every single Skylark method invocation CPU and memory
usage quickly adds up and shows up on profiler samples a lot.