Windows, test-wrapper: write undecl. out annot. #6658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit: - Implement logic to write the undeclared outputs annotations file. This file is just a concatenation of all *.part files directly under $TEST_UNDECLARED_OUTPUTS_ANNOTATIONS_DIR. - Implement depth limit support for the method that retrieves the contents of a directory and all of its subdirectories (GetFileListRelativeTo). We need this feature to limit the *.part file search to just the $TEST_UNDECLARED_OUTPUTS_ANNOTATIONS_DIR, excluding its subdirectories. See: bazelbuild#5508 Change-Id: I566bc7e713bce2fe9950707295a85878e8cf49f8
meteorcloudy
approved these changes
Nov 12, 2018
Change-Id: I1e54eb9bf0476b36693b422771663adeb03bdcd3
|
Thanks! |
meteorcloudy
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit:
Implement logic to write the undeclared outputs
annotations file. This file is just a
concatenation of all *.part files directly under
$TEST_UNDECLARED_OUTPUTS_ANNOTATIONS_DIR.
Implement depth limit support for the method
that retrieves the contents of a directory and
all of its subdirectories
(GetFileListRelativeTo). We need this feature to
limit the *.part file search to just the
$TEST_UNDECLARED_OUTPUTS_ANNOTATIONS_DIR,
excluding its subdirectories.
See: #5508
Change-Id: I566bc7e713bce2fe9950707295a85878e8cf49f8