Python: 2to3 is now a write_file, not sh_binary #8187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now py_* rules no longer depend on a sh_* rule, so Bazel can analyze them even with --shell_executable="". Change-Id: I8e74d86daf385442df9e91c2dc2f7a27b7c4b236
Change-Id: I04ff5791ec135f3bf5a8d26d54674a75a7c76e25
laszlocsomor
changed the title
brandjon
approved these changes
Apr 29, 2019
|
I'm guessing the bootstrapping failures in CI are because you need to add the new bzl file here in order for the (copied and renamed) BUILD.tools file to be usable. |
Change-Id: I78057362c0f4e761362ae1d363eee9c52d3c1295
|
Done. Also added an error message to the generated 2to3, pointing to #1393 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now py_* rules no longer depend on a sh_* rule, so
Bazel can analyze them even with
--shell_executable="".
Change-Id: I8e74d86daf385442df9e91c2dc2f7a27b7c4b236