Skip to content

Commit

Permalink
Revert Windows MSI creation. (#785)
Browse files Browse the repository at this point in the history
This is failing in release 0.29.0.

Fixes #784.

Needs to be addressed in
bazelbuild/bazel#8813.

Revert "Windows, release pipeline: build .msi package (#745) (#782)"

This reverts commit c2bc203.
  • Loading branch information
katre authored and fweikert committed Aug 2, 2019
1 parent a77f8d1 commit ba368b3
Showing 1 changed file with 0 additions and 19 deletions.
19 changes: 0 additions & 19 deletions pipelines/bazel-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -146,25 +146,6 @@ steps:
move bazel-bin\src\bazel artifacts\bazel-%RELEASE_NAME%-windows-x86_64.exe
move bazel-genfiles\scripts\packages\bazel.zip artifacts\bazel-%RELEASE_NAME%-windows-x86_64.zip
rem # The "scripts" directory is taken from the release branch.
rem # Commit 874fe75428 contains a vital bugfix for make_msi_lib.ps1, so only build the .msi
rem # if the release branch has that commit.
rem # TODO(laszlocsomor) remove this version check and build the .msi unconditionally after
rem # Bazel 0.29 (the first version whose release branch will have 874fe75428) is released.
rem #
rem # git merge-base fails if the commit is not an ancestor. While this is expected, it fails
rem # the whole pipeline because BuildKite checks ERRORLEVEL after every command. So we wrap
rem # the git call in a batch file.
echo git merge-base --is-ancestor 874fe754282651bdf006c06147842cbb226c6ae9 HEAD 2^>nul >>check-rev.bat
echo if "%%ERRORLEVEL%%" equ "0" (echo y^>run_ps.txt) else (echo n^>run_ps.txt) >>check-rev.bat
echo exit /b 0 >>check-rev.bat
call check-rev.bat
SET /p RUN_PS_VALUE=<run_ps.txt
DEL /q run_ps.txt
if "%RUN_PS_VALUE%" equ "y" (call powershell scripts\packages\msi\make_msi.ps1 artifacts\bazel-%%RELEASE_NAME%%-windows-x86_64.exe)
cd artifacts
buildkite-agent artifact upload "*"
Expand Down

0 comments on commit ba368b3

Please sign in to comment.