shell_commands should fail immediately if one of the commands fails #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that shell_commands are joined with newlines and then run in a single subprocess.run call, in which case the return value is that of the last command- any failures in previous commands are ignored. Users probably expect such failures to cause the entire build to fail. Changing this behaviour feels like the right thing to do, even though it may cause some projects to fail CI until the corresponding errors are fixed. By prepending "set -e" to the shell commands, the shell will exit immediately with an error code when a command fails (apart from some special cases like if conditions or commands followed by ||). This might fix bazelbuild#938 for linux/mac.
mostynb
added a commit
to mostynb/remote-apis-sdks
that referenced
this pull request
Mar 5, 2020
This may not be needed if this bazelci PR lands: bazelbuild/continuous-integration#957
ola-rozenfeld
pushed a commit
to bazelbuild/remote-apis-sdks
that referenced
this pull request
Mar 16, 2020
* presubmit: shell_commands should exit if any command fails This may not be needed if this bazelci PR lands: bazelbuild/continuous-integration#957 * presubmit: use consistent indentation
philwo
approved these changes
Mar 17, 2020
philwo
added a commit
to bazelbuild/remote-apis-sdks
that referenced
this pull request
Mar 19, 2020
This was made the default in bazelbuild/continuous-integration#957.
ifoox
pushed a commit
to bazelbuild/remote-apis-sdks
that referenced
this pull request
Mar 19, 2020
This was made the default in bazelbuild/continuous-integration#957.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that shell_commands are joined with newlines and then run in a single subprocess.run call, in which case the return value is that of the last command- any failures in previous commands are ignored.
Users probably expect such failures to cause the entire build to fail. Changing this behaviour feels like the right thing to do, even though it may cause some projects to fail CI until the corresponding errors are fixed.
By prepending "set -e" to the shell commands, the shell will exit immediately with an error code when a command fails (apart from some special cases like if conditions or commands followed by ||).
This might fix #938 for linux/mac.