Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit "set -e" from presubmit.yml #131

Merged
merged 1 commit into from Mar 19, 2020
Merged

Remove explicit "set -e" from presubmit.yml #131

merged 1 commit into from Mar 19, 2020

Conversation

@philwo
Copy link
Member

philwo commented Mar 19, 2020

This was made the default in bazelbuild/continuous-integration#957.

This was made the default in bazelbuild/continuous-integration#957.
@googlebot googlebot added the cla: yes label Mar 19, 2020
@mostynb

This comment has been minimized.

Copy link
Contributor

mostynb commented Mar 19, 2020

Thanks (and sorry for the noise in this repo).

@ifoox
ifoox approved these changes Mar 19, 2020
@ifoox ifoox merged commit 7476b11 into master Mar 19, 2020
6 checks passed
6 checks passed
buildkite/remote-apis-sdks Build #582 passed (1 minute, 16 seconds)
Details
buildkite/remote-apis-sdks/cop-validate-bazelci-slash-presubmit-dot-yml Passed (3 seconds)
Details
buildkite/remote-apis-sdks/go-build-slash-test-on-ubuntu-18-dot-04-openjdk-11 Passed (58 seconds)
Details
buildkite/remote-apis-sdks/pipeline Passed (4 seconds)
Details
buildkite/remote-apis-sdks/ubuntu-18-dot-04-openjdk-11 Passed (1 minute, 7 seconds)
Details
cla/google All necessary CLAs are signed
@ifoox

This comment has been minimized.

Copy link
Collaborator

ifoox commented Mar 19, 2020

Thanks Philipp!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.