-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protobufs recompiles when switching between Intellij & CLI #1169
Comments
This could be due to a different Try adding |
my
alas, the problem persists |
@KaoruDev try add this lines in your project .bazelrc:
|
@asv yep, that did it! thanks! |
This was referenced Mar 16, 2020
lolski
pushed a commit
to typedb/typedb
that referenced
this issue
Mar 17, 2020
## What is the goal of this PR? Previously, when switching between IDE and terminal builds, build cache would be fully invalidated. due to changed $PATH which defeats the sole purpose of caching. As per suggestion in [this](bazelbuild/intellij#1169) thread, we're enabling strict environment for actions (which sets PATH alongside with other variables to minimally viable preconfigured values). ## What are the changes implemented in this PR? Specify `--incompatible_strict_action_env` for `build`/`test`/`run`
This was referenced Mar 17, 2020
vmax
added a commit
to typedb/typedb-driver-python
that referenced
this issue
Mar 17, 2020
## What is the goal of this PR? Previously, when switching between IDE and terminal builds, build cache would be fully invalidated. due to changed $PATH which defeats the sole purpose of caching. As per suggestion in [this](bazelbuild/intellij#1169) thread, we're enabling strict environment for actions (which sets PATH alongside with other variables to minimally viable preconfigured values). ## What are the changes implemented in this PR? Specify `--incompatible_strict_action_env` for `build`/`test`/`run`
haikalpribadi
pushed a commit
to typedb/typedb-driver
that referenced
this issue
Mar 18, 2020
## What is the goal of this PR? Previously, when switching between IDE and terminal builds, build cache would be fully invalidated. due to changed $PATH which defeats the sole purpose of caching. As per suggestion in [this](bazelbuild/intellij#1169) thread, we're enabling strict environment for actions (which sets PATH alongside with other variables to minimally viable preconfigured values). ## What are the changes implemented in this PR? Specify `--incompatible_strict_action_env` for `build`/`test`/`run`
This was referenced Mar 18, 2020
vmax
added a commit
to typedb/dependencies
that referenced
this issue
Mar 18, 2020
## What is the goal of this PR? Previously, when switching between IDE and terminal builds, build cache would be fully invalidated. due to changed $PATH which defeats the sole purpose of caching. As per suggestion in [this](bazelbuild/intellij#1169) thread, we're enabling strict environment for actions (which sets PATH alongside with other variables to minimally viable preconfigured values). ## What are the changes implemented in this PR? Specify `--incompatible_strict_action_env` for `build`/`test`/`run`
vmax
added a commit
to typedb/typedb-docs
that referenced
this issue
Mar 18, 2020
## What is the goal of this PR? Previously, when switching between IDE and terminal builds, build cache would be fully invalidated. due to changed $PATH which defeats the sole purpose of caching. As per suggestion in [this](bazelbuild/intellij#1169) thread, we're enabling strict environment for actions (which sets PATH alongside with other variables to minimally viable preconfigured values). ## What are the changes implemented in this PR? Specify `--incompatible_strict_action_env` for `build`/`test`/`run`
haikalpribadi
pushed a commit
to typedb/typedb-common
that referenced
this issue
Mar 18, 2020
## What is the goal of this PR? Previously, when switching between IDE and terminal builds, build cache would be fully invalidated. due to changed $PATH which defeats the sole purpose of caching. As per suggestion in [this](bazelbuild/intellij#1169) thread, we're enabling strict environment for actions (which sets PATH alongside with other variables to minimally viable preconfigured values). ## What are the changes implemented in this PR? Specify `--incompatible_strict_action_env` for `build`/`test`/`run`
vmax
added a commit
to typedb/typedb-driver-nodejs
that referenced
this issue
Apr 14, 2020
## What is the goal of this PR? Previously, when switching between IDE and terminal builds, build cache would be fully invalidated. due to changed $PATH which defeats the sole purpose of caching. As per suggestion in [this](bazelbuild/intellij#1169) thread, we're enabling strict environment for actions (which sets PATH alongside with other variables to minimally viable preconfigured values). ## What are the changes implemented in this PR? Specify `--incompatible_strict_action_env` for `build`/`test`/`run`
flyingsilverfin
pushed a commit
to typedb/typedb-console
that referenced
this issue
Jun 17, 2020
## What is the goal of this PR? Previously, when switching between IDE and terminal builds, build cache would be fully invalidated. due to changed $PATH which defeats the sole purpose of caching. As per suggestion in [this](bazelbuild/intellij#1169) thread, we're enabling strict environment for actions (which sets PATH alongside with other variables to minimally viable preconfigured values). ## What are the changes implemented in this PR? Specify `--incompatible_strict_action_env` for `build`/`test`/`run`
irfansharif
added a commit
to irfansharif/cockroach
that referenced
this issue
Oct 22, 2021
Fixes cockroachdb#71835. When switching between using `dev` and `bazel` raw, I kept seeing our C++ protobuf dependency getting recompiled (slowly). It appears that the bazel build for protobuf has a dependency on $PATH (see bazelbuild/intellij#1169 and bazelbuild/bazel#7095). Specifying `--incompatible_strict_action_env` pins PATH and avoids the build cache thrashing we were seeing before. Release note: None
irfansharif
added a commit
to irfansharif/cockroach
that referenced
this issue
Oct 22, 2021
Fixes cockroachdb#71835. When switching between using `dev` and `bazel` raw, I kept seeing our C++ protobuf dependency getting recompiled (slowly). It appears that the bazel build for protobuf has a dependency on $PATH (see bazelbuild/intellij#1169 and bazelbuild/bazel#7095). Specifying `--incompatible_strict_action_env` pins PATH and avoids the build cache thrashing we were seeing before. Release note: None
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this issue
Oct 22, 2021
71632: sql: make sure pgwire bind always happens in a transaction r=otan a=rafiss fixes #70378 and maybe #64140 The approach of using a transaction matches what we do for pgwire Parse messages already. This is important to make sure that user-defined types are leased correctly. This also updated the SQL EXECUTE command to resolve user-defined types so that it gets the latest changes. Release note (bug fix): Adding new values to a user-defined enum type will previously would cause a prepared statement using that type to not work. This now works as expected. 71836: clusterversion: introduce 22.1 development versions r=celiala a=celiala Fix: #69828 Looking at past Version values for `Start{XX_X}`, I think the `Version` value for `Key: Start22_1` should instead be `Major: 21, Minor: 2, ...`. Start21_1 (from #70268): ``` // v21.1 versions. Internal versions defined here-on-forth must be even. { Key: Start21_1, Version: roachpb.Version{Major: 20, Minor: 2, Internal: 2}, }, ``` Start 21_2: ``` { Key: Start21_2, Version: roachpb.Version{Major: 21, Minor: 1, Internal: 1102}, }, ``` Release justification: Non-production code change. Release note: None 71856: bazel: skip recompilation when using dev+bazel r=irfansharif a=irfansharif Fixes #71835. When switching between using `dev` and `bazel` raw, I kept seeing our C++ protobuf dependency getting recompiled (slowly). It appears that the bazel build for protobuf has a dependency on $PATH (see bazelbuild/intellij#1169 and bazelbuild/bazel#7095). Specifying [`--incompatible_strict_action_env`](https://docs.bazel.build/versions/main/command-line-reference.html#flag--incompatible_strict_action_env) pins PATH and avoids the build cache thrashing we were seeing before. Release note: None Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com> Co-authored-by: Celia La <celiala456@gmail.com> Co-authored-by: irfan sharif <irfanmahmoudsharif@gmail.com>
vorburger
added a commit
to enola-dev/enola
that referenced
this issue
Feb 20, 2023
vorburger
added a commit
to enola-dev/enola
that referenced
this issue
Mar 12, 2023
vorburger
added a commit
to enola-dev/enola
that referenced
this issue
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Observation
Whenever I switch between running commands on the shell and syncing on Intellij I see logs pertaining to compiling protobufs. It only happens on the first command run or sync. Thereafter, I can only assume Bazel is using a cache.
Expectation
I'd expect Bazel to not have to re-compile protobufs every time.
Reproduce
Env
Bazel version:
Plugin version:
2019.08.19.0.5
The text was updated successfully, but these errors were encountered: