Ignore domain sockets #549
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the Mac, git fsmonitor uses a domain socket in the .git/ folder to keep track of the fsmonitor process. cas chokes on that (see https://crbug.com/40270112). Therefore, ignore domain sockets.
mrahs
reviewed
Apr 9, 2024
|
Also, CI wants |
mrahs
reviewed
Apr 9, 2024
mrahs
approved these changes
Apr 9, 2024
avidrissman
added a commit
to avidrissman/remote-apis-sdks
that referenced
this pull request
May 20, 2024
Correct bazelbuild#549. The intention was to skip the file with an unexpected mode, but the “nil, nil” return was actually done in a nested function. Return ErrSkip to escape the nested function, and correctly return “nil, nil” from visitPath, as was intended.
mrahs
pushed a commit
that referenced
this pull request
May 21, 2024
Correct #549. The intention was to skip the file with an unexpected mode, but the “nil, nil” return was actually done in a nested function. Return ErrSkip to escape the nested function, and correctly return “nil, nil” from visitPath, as was intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the Mac, git fsmonitor uses a domain socket in the .git/ folder to keep track of the fsmonitor process. cas chokes on that (see https://crbug.com/40270112).
Therefore, ignore domain sockets.