Ignore unexpected file modes #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct bazelbuild#549. The intention was to skip the file with an unexpected mode, but the “nil, nil” return was actually done in a nested function. Return ErrSkip to escape the nested function, and correctly return “nil, nil” from visitPath, as was intended.
|
I was foolish with the original patch, assuming it was trivial enough that I didn’t need to test it. This patch has been tested in-place with LUCI, and it works. |
|
@mrahs Can you ptal? Thanks. |
mrahs
approved these changes
May 21, 2024
hubot
pushed a commit
to luci/luci-go
that referenced
this pull request
May 21, 2024
To pick up bazelbuild/remote-apis-sdks#573 R=chanli@chromium.org, iannucci@chromium.org BUG=b:341233006 Change-Id: Ic4aa85943d5b4d8f04c8e49f3f748865acc9b984 Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/5556143 Reviewed-by: Chan Li <chanli@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct #549.
The intention was to skip the file with an unexpected mode, but the “nil, nil” return was actually done in a nested function.
Return ErrSkip to escape the nested function, and correctly return “nil, nil” from visitPath, as was intended.