remove dependency on experimental gRPC API #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The custom balancer depends on experimental APIs from grpc-go. It has since been replaced with a simple round robin balancer that has been working well in production. Fixes bazelbuild#499
gkousik
approved these changes
Jun 3, 2024
|
Would we need any reproxy changes in how the SDK is initialized when importing this new SDK version? |
I'm reusing |
|
Ok sg, just wanted us to be aware of it (if not, perhaps better to just do the import now in reclient?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom balancer depends on experimental APIs from grpc-go. It has since been replaced with a simple round robin balancer that has been working well in production.
Fixes #499