-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify OutputFile.path and OutputDirectory.path relativeness #25
Comments
Oh, it was changed on purpose, because we now allow modifying the working directory: https://github.com/bazelbuild/remote-apis/blob/master/build/bazel/remote/execution/v2/remote_execution.proto#L478 |
Thanks for the details @ola-rozenfeld! Isn't it misleading for |
Oh! Haha, yes, sorry, I only now understood you fully -- yes, it's supposed to say working directory everywhere, of course. Fixing now. Thank you! |
In REAPI v1
OutputFile.path
andOutputDirectory.path
where both documented as:But now, in REAPI v2,
OutputDirectory.path
documentation changed for :There doesn't seem to be any good reason for
OutputFile.path
andOutputDirectory.path
to be relative to different root, neither there is to depend on a root (working directory) that is define outside of the current message scope.Any reasons why
OutputDirectory.path
relativeness had been changed?I think that this modification has been introduced by mistake.
The text was updated successfully, but these errors were encountered: