Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: ProguardMapping is not queryable nor deterministically generated #195

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: ProguardMapping is not queryable nor deterministically generated #195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions rules/android_binary_internal/rule.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ load(
"//rules:attrs.bzl",
_attrs = "attrs",
)

load(":attrs.bzl", "ATTRS")
load(":impl.bzl", "impl")

Expand Down Expand Up @@ -52,6 +53,8 @@ def make_rule(
"@bazel_tools//tools/jdk:toolchain_type",
] + additional_toolchains,
_skylark_testable = True,
outputs = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this only a valid change if android_binary outputs proguard mappings for every single android_binary target, which wouldn't be true for local debug APKs that don't run proguard.

"proguard_mapping" : "%{name}" + "_proguard.map"},
fragments = [
"android",
"java",
Expand Down