Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundle_name attribute to all bundling rules to override target name #70

Closed
allevato opened this issue May 18, 2017 · 2 comments
Closed

Comments

@allevato
Copy link
Member

Sometimes you don't want to use the target's name as the bundle's name, so we should add an optional bundle_name attribute that lets the user override that.

For example, currently this produces Foo.app and it can't be changed:

ios_application(
    name = "Foo",
    ...
)

So we should add this to get SomethingOtherThanFoo.app (note that the extension is still determined by the rule):

ios_application(
    name = "Foo",
    bundle_name = "SomethingOtherThanFoo",
    ...
)
@rahul-malik
Copy link
Contributor

@allevato - Any sense of when this might be available? I'm currently trying to build a workaround at the moment for this issue.

allevato added a commit that referenced this issue May 23, 2017
Fixes #70.

RELNOTES: None.
PiperOrigin-RevId: 156862341
allevato added a commit that referenced this issue May 23, 2017
Fixes #70.

RELNOTES: None.
PiperOrigin-RevId: 156862341
@allevato
Copy link
Member Author

@rahul-malik This is done now in master for applications/extensions/frameworks. It won't work yet for objc_bundle_library targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants