Propagate Swift-specific linker flags as an implicit dependency of the toolchain. #1186
Conversation
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
| swiftdeps = [x for x in ctx.rule.attr.deps if SwiftInfo in x] | ||
| ccinfos = [x for x in ctx.rule.attr.deps if CcInfo in x] | ||
| swiftdeps = [x for x in [target] if SwiftInfo in x] | ||
| ccinfos = [x for x in [target] if CcInfo in x] |
There was a problem hiding this comment.
This is great! It cleans up the implementation a lot and makes more sense without the swift_runtime_linkopts dependency
segiddins
force-pushed
the
segiddins/c253e4fa18d6f95ac065021b28662c4ddb37b149
branch
from
923543e
to
39f6a6b
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
Now passing with HEAD deps, so we should be able to merge this once we cut a |
|
Lyft integration job started: https://buildkite.com/lyft/ios/builds/705959#a7effed9-8c0b-4888-9cfc-d9487add73d7 (must be Lyft employee to view) |
…e toolchain. Apple binaries/bundles will automatically get these linker flags if they have any Swift target in their dependencies; this eliminates the need to pass them separately at the top level. PiperOrigin-RevId: 378024438 (cherry picked from commit c253e4f) # Conflicts: # apple/internal/binary_support.bzl
segiddins
force-pushed
the
segiddins/c253e4fa18d6f95ac065021b28662c4ddb37b149
branch
from
39f6a6b
to
83a1246
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
passed for us |
…e toolchain. Apple binaries/bundles will automatically get these linker flags if they have any Swift target in their dependencies; this eliminates the need to pass them separately at the top level. PiperOrigin-RevId: 378024438
Propagate Swift-specific linker flags as an implicit dependency of the toolchain.
Apple binaries/bundles will automatically get these linker flags if they have any Swift target in their dependencies; this eliminates the need to pass them separately at the top level.
PiperOrigin-RevId: 378024438
(cherry picked from commit c253e4f)
Conflicts:
apple/internal/binary_support.bzl