Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch static xcframework rule to produce framework #1488

Merged

Commits on May 28, 2022

  1. Switch static xcframework rule to produce framework

    Previously the apple_static_xcframework rule produced a xcframework that
    wrapped a static library. This change makes it produce a static
    framework instead. A static framework has the benefit that headers are
    easier to deal with in 2 ways (at least when including with bazel):
    
    1. You don't need to set any `includes` on the import, reducing `-I`
       flags up the tree (since they're covered by the `-F` instead
    2. Module style imports `#import <foo/foo.h>` are supported without any
       other infra, with libraries only quoted imports work without
       headermaps or another solution
    
    The reason this wasn't done originally is that Xcode doesn't support
    copying resources in static xcframeworks. While this is the same with
    libraries and frameworks, the difference is users might expect resources
    nested in framework bundles to be copied, but they will not be, and
    users may expect that in the static library case, since libraries don't
    ever manage resource inclusion. It sounds like CocoaPods handles this
    transparently, but Xcode does not FB10026748.
    keith committed May 28, 2022
    Configuration menu
    Copy the full SHA
    43c02b4 View commit details
    Browse the repository at this point in the history