Add extension_safe to apple_xcframework #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most importantly this passes the `-fapplication-extension` linkopt. Right now this doesn't do anything else, because the application extension partial only validates the `frameworks` attr, which these don't end up in. There is a TODO in that file to improve that.
keith
requested review from
BalestraPatrick,
brentleyjones,
segiddins,
thii and
mattrobmattrob
as code owners
jpsim
approved these changes
Sep 21, 2023
brentleyjones
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most importantly this passes the
-fapplication-extensionlinkopt.Right now this doesn't do anything else, because the application
extension partial only validates the
frameworksattr, which thesedon't end up in. There is a TODO in that file to improve that.