Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codesigningtool to work with openssl 3 #2285

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Conversation

Jichao
Copy link
Contributor

@Jichao Jichao commented Oct 12, 2023

Hello maintainers,

I'm submitting this pull request to address an issue that occurs when the version of openssl is upgraded to 3+. codingsigningtool.py could not calculate the sha1 fingerprint correctly.

Steps to Reproduce:

  1. brew install openssl@3
    ensure 'which openssl' point to openssl@3
  2. any ios_app using local_provisioning_profile
  3. bazel build would fail with
    ERROR: Unable to find an identity on the system matching the ones in xxxx.mobileprovision

Expected Behavior:
No error

Reason:
The output of openssl is changed.

openssl3
openssl x509 -sha1 -inform PEM -noout -fingerprint -in certificate.pem
sha1 Fingerprint=DF:4B:EA:DB:C9:76:38:55:B8:5B:30:0B:6A:88:CF:E4:9F:XX:XX:XX
openssl 1.1
SHA1 Fingerprint=DF:4B:EA:DB:C9:76:38:55:B8:5B:30:0B:6A:88:CF:E4:9F:XX:XX:XX

Proposed Solution:

fingerprint = fingerprint.replace("SHA1 Fingerprint=", "")
++fingerprint = fingerprint.replace("sha1 Fingerprint=", "")

Best regards,
Jichao

@thii thii merged commit d0180e6 into bazelbuild:master Oct 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants