Include dSYMs for any bundled extension targets in the app's xcarchive #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jszumski
requested review from
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob,
segiddins and
thii
as code owners
jszumski
force-pushed
the
jszumski/xcarchive-extension-dsyms
branch
2 times, most recently
from
e77abbc
to
794b6f4
Compare
luispadron
approved these changes
Nov 7, 2023
|
@brentleyjones can you take another look when you get a chance |
brentleyjones
approved these changes
Nov 7, 2023
jszumski
force-pushed
the
jszumski/xcarchive-extension-dsyms
branch
from
794b6f4
to
d51594c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes dSYMs for transitive targets in a generated xcarchive.
I added tests to ensure dSYMs are included when
apple_generate_dsym = Truefor apps with and without extensions.