Add support for clang modules in experimental_mixed_language_library #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
requested review from
BalestraPatrick,
brentleyjones,
keith,
mattrobmattrob and
thii
as code owners
luispadron
force-pushed
the
lpadron/Add_support_for_clang_modules_in_experimental_mixed_language_library
branch
from
9b939a2
to
34d8b43
Compare
mattrobmattrob
approved these changes
Dec 31, 2023
thii
approved these changes
Jan 1, 2024
luispadron
force-pushed
the
lpadron/Add_support_for_clang_modules_in_experimental_mixed_language_library
branch
from
34d8b43
to
f55aabd
Compare
luispadron
deleted the
lpadron/Add_support_for_clang_modules_in_experimental_mixed_language_library
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
@importwhen usingexperimental_mixed_language_library. There seems to be a "bug" (or at least a usability issue) in Bazel where ifmodule_mapis set onobjc_librarythen theenable_modulesattr does nothing.This enables modules via copts instead, similar to how it was done in rules_apple_line.