Remove ctx.resolve_tools in favor of ctx.actions.run(executable = …) and ctx.actions.run(tools = ...).
#2438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjgq
force-pushed
the
resolve-tools
branch
2 times, most recently
from
ed3ee93
to
02390d6
Compare
tjgq
requested review from
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
brentleyjones
approved these changes
Mar 27, 2024
…...)` and `ctx.actions.run(tools = ...)`. By passing the files_to_run for a tool into the `executable` or `tools` argument to `ctx.actions.run` or `ctx.actions.run_shell`, it's no longer necessary to pass the return values of `ctx.resolve_tools` into the `inputs` and `input_manifests` arguments. Each struct field of the AppleMacToolsToolchainInfo and AppleXPlatToolsToolchainInfo providers previously populated with the return values of `ctx.resolve_tools` is now populated with the files_to_run for the respective tool. The `resolved_` prefix is removed from field and variable names; in addition to it no longer making sense, this change provides proof that all usages have been audited. This lets us retire the `ctx.resolve_tools` API in a future Bazel version.
luispadron
added a commit
to bazel-ios/rules_ios
that referenced
this pull request
Apr 5, 2024
rules_apple 3.5.0 broke `resolved_*` tools from `AppleMacToolchainInfo` (bazelbuild/rules_apple#2438) This sets the new minimum supported version for the next rules_ios release to 3.5.0.
luispadron
added a commit
to bazel-ios/rules_ios
that referenced
this pull request
Apr 5, 2024
rules_apple 3.5.0 broke `resolved_*` tools from `AppleMacToolchainInfo` (bazelbuild/rules_apple#2438) This sets the new minimum supported version for the next rules_ios release to 3.5.0.
|
We should list this as a breaking change in the releases i think, it broke some downstream rules since the |
luispadron
added a commit
to bazel-ios/rules_ios
that referenced
this pull request
Apr 5, 2024
rules_apple 3.5.0 broke `resolved_*` tools from `AppleMacToolchainInfo` (bazelbuild/rules_apple#2438) This sets the new minimum supported version for the next rules_ios release to 3.5.0.
luispadron
added a commit
to bazel-ios/rules_ios
that referenced
this pull request
Apr 5, 2024
rules_apple 3.5.0 broke `resolved_*` tools from `AppleMacToolchainInfo` (bazelbuild/rules_apple#2438) This sets the new minimum supported version for the next rules_ios release to 3.5.0.
luispadron
added a commit
to bazel-ios/rules_ios
that referenced
this pull request
Apr 5, 2024
rules_apple 3.5.0 broke `resolved_*` tools from `AppleMacToolchainInfo` (bazelbuild/rules_apple#2438) This sets the new minimum supported version for the next rules_ios release to 3.5.0.
luispadron
added a commit
to bazel-ios/rules_ios
that referenced
this pull request
Apr 5, 2024
rules_apple 3.5.0 broke `resolved_*` tools from `AppleMacToolchainInfo` (bazelbuild/rules_apple#2438) This sets the new minimum supported version for the next rules_ios release to 3.5.0.
|
That's not public API, right? I think we are free to modify that without any mention. |
|
Yeah you're right. Thought it was in providers.bzl but doesn't look like it |
acecilia
pushed a commit
to revolut-mobile/rules_apple
that referenced
this pull request
Apr 12, 2024
……)` and `ctx.actions.run(tools = ...)`. (bazelbuild#2438) By passing the files_to_run for a tool into the `executable` or `tools` argument to `ctx.actions.run` or `ctx.actions.run_shell`, it's no longer necessary to pass the return values of `ctx.resolve_tools` into the `inputs` and `input_manifests` arguments. Each struct field of the AppleMacToolsToolchainInfo and AppleXPlatToolsToolchainInfo providers previously populated with the return values of `ctx.resolve_tools` is now populated with the files_to_run for the respective tool. The `resolved_` prefix is removed from field and variable names; in addition to it no longer making sense, this change provides proof that all usages have been audited. This lets us retire the `ctx.resolve_tools` API in a future Bazel version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By passing the files_to_run for a tool into the
executableortoolsargument toctx.actions.runorctx.actions.run_shell, it's no longer necessary to pass the return values ofctx.resolve_toolsinto theinputsandinput_manifestsarguments.Each struct field of the AppleMacToolsToolchainInfo and AppleXPlatToolsToolchainInfo providers previously populated with the return values of
ctx.resolve_toolsis now populated with the files_to_run for the respective tool.The
resolved_prefix is removed from field and variable names; in addition to it no longer making sense, this change provides proof that all usages have been audited.This lets us retire the
ctx.resolve_toolsAPI in a future Bazel version.