Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docc rule to support deps and data #2450

Merged

Conversation

luispadron
Copy link
Contributor

Updates the .docc aspect to allow both deps and data attributes as providers for the .docc bundle information. Previously, if the rule defined data but had no DocC bundle we'd lose out on any docc bundle information from the deps.

@mattrobmattrob
Copy link
Contributor

Possible to add a test case to cover this scenario?

@luispadron luispadron force-pushed the luis/update-docc-rule-for-better-docc-bundle-support branch from e6adf4c to 9f4b142 Compare April 22, 2024 15:08
@luispadron luispadron marked this pull request as ready for review April 22, 2024 15:08
@luispadron luispadron force-pushed the luis/update-docc-rule-for-better-docc-bundle-support branch from 9f4b142 to 618033b Compare April 22, 2024 15:32
@luispadron
Copy link
Contributor Author

Some weird failures on last_green, not sure theyre related as the test i wrote is passing in the other jobs

@brentleyjones
Copy link
Collaborator

brentleyjones commented Apr 22, 2024

Failed on a re-run. We should confirm locally that it still fails (on master), and if so, start to bazelisk bisect to see when it broke in bazel.

@luispadron luispadron force-pushed the luis/update-docc-rule-for-better-docc-bundle-support branch from 618033b to 8ba3daf Compare April 24, 2024 19:36
Updates the `.docc` aspect to allow both `deps` and `data` attributes as providers for the `.docc` bundle information.
Previously, if the rule defined `data` but had no DocC bundle we'd lose out on any docc bundle information from the deps.
@luispadron luispadron force-pushed the luis/update-docc-rule-for-better-docc-bundle-support branch from 8ba3daf to 2dca506 Compare April 25, 2024 15:22
@luispadron
Copy link
Contributor Author

luispadron commented Apr 26, 2024

CI seems a bit flaky due to simulator issues and i dont have permissions to retry

   Failure Reason: Failed to create SimDeviceSet at path /Users/buildkite/Library/Developer/Xcode/UserData/IB Support/Simulator Devices. You'll want to check the logs in ~/Library/Logs/CoreSimulator to see why creating the SimDeviceSet failed.
            Description: Unable to determine SimDeviceSet for subscriptions, set_path=/Users/buildkite/Library/Developer/Xcode/UserData/IB Support/Simulator Devices
            Underlying Errors:
    Underlying Errors:
                Failure Reason: Allocation or initialization failed.
                Description: Failed to initialize simulator device set.

@mattrobmattrob
Copy link
Contributor

I've retried the job.

@luispadron luispadron merged commit 23bded2 into master Apr 26, 2024
10 checks passed
@luispadron luispadron deleted the luis/update-docc-rule-for-better-docc-bundle-support branch April 26, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants