-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docc rule to support deps and data #2450
Merged
luispadron
merged 1 commit into
master
from
luis/update-docc-rule-for-better-docc-bundle-support
Apr 26, 2024
Merged
Update docc rule to support deps and data #2450
luispadron
merged 1 commit into
master
from
luis/update-docc-rule-for-better-docc-bundle-support
Apr 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrobmattrob
approved these changes
Apr 18, 2024
Possible to add a test case to cover this scenario? |
e6adf4c
to
9f4b142
Compare
mattrobmattrob
approved these changes
Apr 22, 2024
9f4b142
to
618033b
Compare
Some weird failures on last_green, not sure theyre related as the test i wrote is passing in the other jobs |
Failed on a re-run. We should confirm locally that it still fails (on |
618033b
to
8ba3daf
Compare
Updates the `.docc` aspect to allow both `deps` and `data` attributes as providers for the `.docc` bundle information. Previously, if the rule defined `data` but had no DocC bundle we'd lose out on any docc bundle information from the deps.
8ba3daf
to
2dca506
Compare
CI seems a bit flaky due to simulator issues and i dont have permissions to retry
|
I've retried the job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
.docc
aspect to allow bothdeps
anddata
attributes as providers for the.docc
bundle information. Previously, if the rule defineddata
but had no DocC bundle we'd lose out on any docc bundle information from the deps.