Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort load statements per buildifier 6.4.0 #2499

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Sort load statements per buildifier 6.4.0 #2499

merged 1 commit into from
Jul 12, 2024

Conversation

erikkerber
Copy link
Contributor

Followup request from #2485

rules_apple is on buildifier 6.3.2, one version before load sorting improvements. Can update that too.

@erikkerber erikkerber marked this pull request as ready for review July 12, 2024 02:08
luispadron
luispadron approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@luispadron luispadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I can finally run buildifier without it rewriting a bunch of stuff I didn't modify ha

@erikkerber erikkerber changed the title Buildifier 6.4.0+ sorting of load statements Sort load statements per buildifier 6.4.0 Jul 12, 2024
@erikkerber erikkerber mentioned this pull request Jul 12, 2024
Merged
@brentleyjones brentleyjones merged commit 6db5fb0 into bazelbuild:master Jul 12, 2024
7 of 9 checks passed
brentleyjones pushed a commit that referenced this pull request Jul 12, 2024
@erikkerber
Use buildifier 6.4.0 for improved load sorting (#2500)
90ec747 
Followup to/depends on #2499 

Bigger PR than 2499 due to me not including `.bzl` files. I was using a
command from my history that just operated on BUILD/MODULE files. Big
enough it might make upstream merges a little painful? I'll leave that
thought to the maintainers.

**6.3.3:** `out_of_order_load` warning is enabled by default
**6.4.0:** More correct sorting order of load statements

Could bump to 7.1.2 which is latest, but not necessary for auto fixing
of load sorting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentleyjones brentleyjones brentleyjones approved these changes

@luispadron luispadron luispadron approved these changes

@BalestraPatrick BalestraPatrick Awaiting requested review from BalestraPatrick BalestraPatrick is a code owner

@keith keith Awaiting requested review from keith keith is a code owner

@mattrobmattrob mattrobmattrob Awaiting requested review from mattrobmattrob mattrobmattrob is a code owner

@thii thii Awaiting requested review from thii thii is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erikkerber @brentleyjones @luispadron