Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substitute DEVELOPMENT_LANGUAGE variable with en in resource bundle's Info.plist #680

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

thii
Copy link
Member

@thii thii commented Dec 20, 2019

This supports compiling Info.plist out of the box coming from Xcode.

This is similar with #475 but for apple_resource_bundle rule.

Info.plist

This supports compiling Info.plist out of the box coming from Xcode.
@keith
Copy link
Member

keith commented Dec 20, 2019

FWIW we hard coded this in all our plists manually

@thii
Copy link
Member Author

thii commented Dec 20, 2019

We have a lot of them including the ones from external dependencies, and the new ones from Xcode always have this. Asking people to manually modify it every time is not so intuitive IMO.

@thii
Copy link
Member Author

thii commented Dec 20, 2019

We came up with the solution of using a genrule to modify the Info.plist before giving it to apple_resource_bundle for now. But I prefer using as less hacks as I can.

@keith
Copy link
Member

keith commented Dec 20, 2019

Yea seems reasonable. Especially since this is set in other places.

@keith
Copy link
Member

keith commented Aug 7, 2020

at some point this started happening it seems

# The generated Info.plists from Xcode's project templates use
# DEVELOPMENT_LANGUAGE as the default variable substitution for
# CFBundleDevelopmentRegion. We substitute this to `en` to support
# Info.plists out of the box coming from Xcode.
substitutions["DEVELOPMENT_LANGUAGE"] = "en"

@keith keith closed this Aug 7, 2020
@thii
Copy link
Member Author

thii commented Aug 7, 2020

That's for the root Info plists. This one is still needed.

@keith keith reopened this Aug 7, 2020
@keith
Copy link
Member

keith commented Aug 7, 2020

Sorry about that, folding mixed me up

@keith keith merged commit 9a87683 into bazelbuild:master Aug 7, 2020
@thii thii deleted the resources-info-plist branch August 7, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants