Substitute DEVELOPMENT_LANGUAGE variable with en in resource bundle's Info.plist
#680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Info.plist This supports compiling Info.plist out of the box coming from Xcode.
|
FWIW we hard coded this in all our plists manually |
|
We have a lot of them including the ones from external dependencies, and the new ones from Xcode always have this. Asking people to manually modify it every time is not so intuitive IMO. |
|
We came up with the solution of using a genrule to modify the Info.plist before giving it to apple_resource_bundle for now. But I prefer using as less hacks as I can. |
|
Yea seems reasonable. Especially since this is set in other places. |
|
at some point this started happening it seems rules_apple/apple/internal/resource_actions/plist.bzl Lines 213 to 217 in 2c37027 |
|
That's for the root Info plists. This one is still needed. |
|
Sorry about that, folding mixed me up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports compiling Info.plist out of the box coming from Xcode.
This is similar with #475 but for
apple_resource_bundlerule.