Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please Update io_bazel_rules_go to remove reference to @bazel_tools//platforms:xxx #140

Closed
aranguyen opened this issue Aug 26, 2022 · 4 comments

Comments

@aranguyen
Copy link
Contributor

aranguyen commented Aug 26, 2022

Description of the problem / feature request:

The flag --incompatible_use_platforms_repo_for_constraints has been flipped and we're seeing CI failures in rules_cc for downstream pipeline https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2600#_

Issue: bazelbuild/continuous-integration#1404

Replace this line with your answer.

Feature requests: what underlying problem are you trying to solve with this feature?

My quick analysis points to the remaining references of bazel_tools//platforms in io_bazel_rules_go. Since rules_go came from bazel_federation

load("@bazel_federation//:repositories.bzl", "bazel_skylib", "protobuf", "rules_go", "rules_python")
, please do the following:

  1. Make a PR to update bazel_federation with the most recent rules_go https://github.com/bazelbuild/bazel-federation/blob/8ce885a3a89da83228cd845c6ab13bb0175ca105/repositories.bzl#L161
  2. Make a PR to update bazel_federation to the most recent commit with updated rules_go
    name = "bazel_federation",

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

bazel build --nobuild ...
bazel info ouput_base
grep -r "@bazel_tools//platforms" <replace with the output of the command bazel info output_base>

What operating system are you running Bazel on?

Replace this line with your answer.

What's the output of bazel info release?

release 5.2.0

What version of rules_cc do you use? Can you paste the workspace rule used to fetch rules_cc? What other relevant dependencies does your project have?

rules_cc at HEAD

@aranguyen
Copy link
Contributor Author

I'm not able to build rules_cc on my machine and got this error ERROR: /Users/aranguyen/rules_cc/examples/custom_toolchain/BUILD:81:19: in cc_toolchain_suite rule //examples/custom_toolchain:legacy_selector: cc_toolchain_suite '//examples/custom_toolchain:legacy_selector' does not contain a toolchain for cpu 'darwin'

If someone could guide me to build rules_cc, I could help with the deps update.

@aiuto
Copy link
Contributor

aiuto commented Aug 26, 2022

We should get rid of the federation indirection. No one is actively maintaining that so it becomes a boondoggle.

@aiuto
Copy link
Contributor

aiuto commented Aug 26, 2022

Without addressing removing the federation indirction, I think #142 is a fix.

@comius
Copy link
Collaborator

comius commented Dec 27, 2023

Stale

@comius comius closed this as not planned Won't fix, can't repro, duplicate, stale Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants