Update WORKSPACE to account for bazel_tool//platforms going away. #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- point to bazelbuild/platforms for @platforms - Use a newer version of rules_go for our internal rules. - Make a bzl file used in a test visible to the tests. I believe this fixes a build breakage in bazel at head and 5.3.0
|
How do we get this merged? |
22 tasks
|
Ah, I see there are outstanding CI failures. |
|
I removed the debugging lines, but TBH, I'm not sure where I left this. I was unexpectedly OOO all of this week so far, and what happened last Friday is a distant memory. Let's see how CI goes. |
|
Gack!!!! We auto-pull? Someone else has to approve that. |
|
Ah.... even stranger, but we can discuss that offline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes a build breakage in bazel at head and 5.3.0 #140
cc: @aranguyen