Introduce webfiles() and development web server #153
Conversation
| manifest_lines = [ctx.label] | ||
| for src in ctx.attr.srcs: | ||
| sname = "/" + src.label.name | ||
| # TODO(jart): Audit algorithm for subpath extraction. |
There was a problem hiding this comment.
Should this TODO make it into the codebase?
| for dep in ctx.attr.deps: | ||
| inputs.append(dep.webfiles.dummy) | ||
| for f in dep.files: | ||
| inputs.append(f) |
There was a problem hiding this comment.
Equivalent to inputs.extend(dep.files), no?
There was a problem hiding this comment.
Unfortunately no.
ERROR: /usr/local/google/home/jart/.cache/bazel/_bazel_jart/9c19469f1b82ef6dc9e1d1c576c7b609/external/iron_flex_layout/BUILD:9:1: in webfiles rule @iron_flex_layout//:iron_flex_layout:
Traceback (most recent call last):
File "/usr/local/google/home/jart/.cache/bazel/_bazel_jart/9c19469f1b82ef6dc9e1d1c576c7b609/external/iron_flex_layout/BUILD", line 9
webfiles(name = 'iron_flex_layout')
File "/usr/local/google/home/jart/.cache/bazel/_bazel_jart/9c19469f1b82ef6dc9e1d1c576c7b609/external/io_bazel_rules_closure/closure/webfiles.bzl", line 69, in _webfiles
inputs.extend(dep.files)
Method list.extend(items: sequence) is not applicable for arguments (set): 'items' is set, but should be sequence.
ERROR: Analysis of target '//tensorflow/tensorboard/components/vz-line-chart/demo:demo' failed; build aborted.
| .put("zip", MediaType.ZIP) | ||
| .build(); | ||
|
|
||
| static final ImmutableSet<MediaType> COMPRESSABLE = |
| private static final String BOLD = "\u001b[1m"; | ||
| private static final String RESET = "\u001b[0m"; | ||
|
|
||
| private static final HostAndPort DEFAULT_BIND = HostAndPort.fromString("[::]:6006"); |
There was a problem hiding this comment.
This will conflict with the default on TensorBoard, which I think is slightly inconvenient.
6006 was chosen for GOOG.
Maybe this time the default should be 600613?
There was a problem hiding this comment.
600613 > 2**16-1 so no dice. But this server has already got you covered. If it can't bind to 6006, it increments the port number and tries again.
| } | ||
| } | ||
| Server server; | ||
| while (true) { |
There was a problem hiding this comment.
The while(true) is so it will keep incrementing ports until it gets one that works?
Maybe comment it or factor it out (if feasible)
| verify(!path.isAbsolute()); | ||
| path = RUNFILES_PATH.resolve(path); | ||
| if (path == null) { | ||
| serveError(SC_BAD_REQUEST, "Naughty naughty!"); |
There was a problem hiding this comment.
Maybe something a bit more descriptive?
There was a problem hiding this comment.
Actually come to think of it, this isn't needed.
|
PTAL |
jart
force-pushed
the
webfiles
branch
2 times, most recently
from
5a67415
to
b1879fb
Compare
|
By the way, I haven't really written a lot of unit tests for this change, even though I should. I did this because I'm favoring velocity. But the tests would make it clearer what the code is doing and prove that it works. So if you want me to write them now rather than later, I will completely understand. |
jart
force-pushed
the
master
branch
5 times, most recently
from
d44f29a
to
dfbec45
Compare
The webfiles() rule has been designed primarily for supporting Polymer web components, but it's general purpose enough to serve the needs of any web developer. It allows each piece of a website to be defined in terms of the relationships between source files. This is validated by checking the src/href/url attributes to make sure the referenced files exist. Vulcanization support will also be reinvented shortly. Each webfiles() rule is executable. It starts a lightweight Jetty web server that serves up the transitive closure of dependencies with directory listings and live source reloading. This rule is capable of serving as a Fileset() replacement, which means it will be extended in the near future create zip/war archives.
|
(This test failure just seems to have been a disk space problem on one machine if the review is waiting for it to go green) |
|
Closing this PR because it's patched as cl/138836345 |
Reviewer: @danmane
This webfiles() rule has been designed primarily for supporting Polymer web components, but it's general purpose enough to serve the needs of any web developer. It allows each piece of a website to be defined in terms of the relationships between source files. This is validated by checking the src/href/url attributes to make sure the referenced files exist. Vulcanization support will also be reinvented shortly.
Each webfiles() rule is executable. It starts a lightweight Jetty web server that serves up the transitive closure of dependencies with directory listings and live source reloading.
This rule is capable of serving as a Fileset() replacement, which means it will be extended in the near future create zip/war archives.